Bug 2213740

Summary:	[Machines] There will be Ooops when adding watchdog to a undefined vm
Product:	Red Hat Enterprise Linux 9	Reporter:	Xianghua Chen <xchen>
Component:	cockpit-machines	Assignee:	Simon Kobyda <skobyda>
Status:	VERIFIED ---	QA Contact:	Xianghua Chen <xchen>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	9.3	CC:	kkoukiou, mpitt, qzhang, wshi, ymao, yunyang
Target Milestone:	rc	Keywords:	Triaged
Target Release:	9.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	cockpit-machines-293-1.el9	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Xianghua Chen 2023-06-09 05:56:01 UTC

Description of problem:
[Machines] There will be Ooops when adding watchdog to a undefined vm

Version-Release number of selected components (if applicable):
cockpit-machines-291-1.el9.noarch
cockpit-292-1.el9.x86_64
libvirt-dbus-1.4.1-5.el9.x86_64
libvirt-client-9.3.0-2.el9.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Prepare a running vm , like cirros. 

2. Undefine it:
# virsh undefine cirros

3. Click "add" of "Watchdog", Select "Pause", then click "Add" on the dialog

There will be Ooops occurs, and the add watchdog dialog hangs there.
Close the dialog, you will find the "Reset" is added successfully.


Actual results:
See step3.


Expected results:
There should be no Ooops and the add watchdog dialog should be closed.

Additional info:

Comment 1 Xianghua Chen 2023-06-09 06:19:31 UTC

Sorry for typo, it's "Pause is added successfully" as result in step 3.

Comment 2 Martin Pitt 2023-06-26 19:30:56 UTC

https://github.com/cockpit-project/cockpit-machines/pull/1118

Comment 3 Simon Kobyda 2023-06-26 21:52:14 UTC

Fix merged: https://github.com/cockpit-project/cockpit-machines/pull/1118

Comment 7 Xianghua Chen 2023-07-05 09:01:31 UTC

Verified with packages:
cockpit-machines-293-1.el9.noarch
cockpit-295-1.el9.x86_64
libvirt-dbus-1.4.1-5.el9.x86_64
libvirt-client-9.3.0-2.el9.x86_64

Steps to Reproduce:
1. Prepare a running vm , like cirros. 

2. Undefine it:
# virsh undefine cirros

3. Click "add" of "Watchdog", Select "Pause", then click "Add" on the dialog

"Pause" is added successfully.

So verified.