Bug 2213746

Summary: [Machines] Edit watchdog failed for undefined vm with not proper error messages
Product: Red Hat Enterprise Linux 9 Reporter: Xianghua Chen <xchen>
Component: cockpit-machinesAssignee: Simon Kobyda <skobyda>
Status: VERIFIED --- QA Contact: Xianghua Chen <xchen>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 9.3CC: kkoukiou, mpitt, qzhang, wshi, ymao, yunyang
Target Milestone: rcKeywords: Triaged
Target Release: 9.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: cockpit-machines-293-1.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Watchdog error none

Description Xianghua Chen 2023-06-09 06:40:27 UTC 
Created attachment 1969870 [details]
Watchdog error

Description of problem:
[Machines] Edit watchdog failed for undefined vm with not proper error messages

Version-Release number of selected components (if applicable):
cockpit-machines-291-1.el9.noarch
cockpit-292-1.el9.x86_64
libvirt-dbus-1.4.1-5.el9.x86_64
libvirt-client-9.3.0-2.el9.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Prepare a running vm , like cirros. 

2. Undefine it:
# virsh undefine cirros

3. Click "add" of "Watchdog", Select "Pause", then click "Add" on the dialog
There is a new bug for this : https://bugzilla.redhat.com/show_bug.cgi?id=2213740

4. Close the dialog, you will find the "Pause" is added successfully. 
Click edit again, select "Reset" this time, click "Save"


Actual results:
There will be 2 icons with error messages on the dialog:
1. Changes will take effect after shutting down the VM
2. Could not dynamically add watchdog
Adding a watchdog will require a reboot to take effect.

But no "Apply on next reboot" button for this.
Refer to screenshot.

Expected results:
Should be able to change watchdog at last, or at least provide proper error message and guide on this .

Additional info:
Comment 1 Martin Pitt 2023-06-26 19:32:17 UTC 
https://github.com/cockpit-project/cockpit-machines/pull/1118
Comment 2 Simon Kobyda 2023-06-26 21:51:46 UTC 
Fix merged: https://github.com/cockpit-project/cockpit-machines/pull/1118
Comment 5 Xianghua Chen 2023-07-05 09:11:34 UTC 
Verified with packages:
cockpit-machines-293-1.el9.noarch
cockpit-295-1.el9.x86_64
libvirt-dbus-1.4.1-5.el9.x86_64
libvirt-client-9.3.0-2.el9.x86_64

Steps:
1. Prepare a running vm , like cirros. 

2. Undefine it:
# virsh undefine cirros

3. Click "add" of "Watchdog", Select "Pause", then click "Add" on the dialog
"Pause" added successfully

4. Click edit again
Save is disabled, and if move to it, there is a hint: "Cannot edit watchdog device on a transient VM"
Select "Reset" this time, save is still disabled.

So verified.