Bug 221376 (python-libtorrent)
| Summary: | Review Request: python-libtorrent - Python bindings to the rb_libtorrent library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Gordon <peter> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | gnomeuser, mtasaka |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-01-28 23:11:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 221372 | ||
| Bug Blocks: | 163779, 221669 | ||
|
Description
Peter Gordon
2007-01-04 05:47:10 UTC
[ Adding David to the CC list at his request; and blocking the rb_libtorrent review requst bug (since that is required as a build dependency). ] I overlooked that RPM does not find the rb_libtorrent dependency through the shared library's linkage dependencies, so I've added that as a hardcoded Requires in release 2. Spec: http://www.thecodergeek.com/downloads/fedora/python-libtorrent.spec SRPM: http://www.thecodergeek.com/downloads/fedora/python-libtorrent-0.3.0-2.src.rpm Thanks. Dang. It needs a bunch of DHT loving which was fixed in SVN. I've therefore packaged the latest SVN with these fixes: Spec: http://www.thecodergeek.com/downloads/fedora/python-libtorrent.spec SRPM: http://www.thecodergeek.com/downloads/fedora/python-libtorrent-0.3.0-3.20061128svn.src.rpm Thanks. I've bumped it to a new release, which adds a -DAMD64 flag on 64-bit arches (as noticed by Gerd Classen on bug #221669). Updated files are on my webspace: Spec: http://thecodergeek.com/downloads/fedora/python-libtorrent.spec SRPM: http://thecodergeek.com/downloads/fedora/python-libtorrent-0.3.0-4.20061128svn.src.rpm Thanks. Well, * Current URL seems to be http://deluge-torrent.org/ * The newest version seems to be 0.4.0 ( http://deluge-torrent.org/wiki/Downloads ) By the way, does this need rb_libtorrent (bug 221372)? * Doesn't this package compile without rb_libtorrent? * Is this python module linked against libtorrent.so? For me, 0.4.0 compile without rb_libtorrent. (In reply to comment #6) > By the way, does this need rb_libtorrent (bug 221372)? This is the python interface to the functionality provided by the rb_libtorrent library. Without rb_libtorrent installed, this package is essentially useless. :] I'm going to be pretty busy the rest of today, so I'll get to updating this tomorrow (probably sometime in the early evening-ish). Thanks. (In reply to comment #7) > (In reply to comment #6) > > By the way, does this need rb_libtorrent (bug 221372)? > > > This is the python interface to the functionality provided by the > rb_libtorrent > library. Yes. As you and the description on http://deluge-torrent.org/wiki says, this (python-libtorrent) is the python interface, which provides the function provided the rb_libtorrent, i.e. the _rewrite_ of rb_libtorrent so that rb_libtorrent can be used from python _directly_. As you can see, the source of python-libtorrent includes the "copy" of rb_libtorrent source, modified so that it can be called by python. I still doubt that this package should need C++ version of libtorrent (rb_libtorrent). (In reply to comment #8) > As you can see, the source of python-libtorrent includes the > "copy" of rb_libtorrent source, modified so that it can be > called by python. I still doubt that this package should need > C++ version of libtorrent (rb_libtorrent). OOOOHHHH....That's icky! Good catch. I wonder if simply removing the internal libtorrent files would make it use the installed system copy...I'll play with it when I get home tonight. I'll need to bug the upstream Deluge people too. Thanks for the catch! I wrote a fixed setup.py (sent upstream) build script which configures the build against and links to the system copy of rb_libtorrent, rather than its own internal copy. I also updated to the latest version (0.4.0). Spec: http://www.thecodergeek.com/downloads/fedora/python-libtorrent.spec SRPM: http://www.thecodergeek.com/downloads/fedora/python-libtorrent-0.4.0-1.src.rpm Thanks! I will review this after rb-libtorrent (bug 221372) is completed. Well, actually the files needed for this package is python-libtorrent.cpp and your setup.py makes sense. * URL, Source0 should be http://deluge-torrent.org/ http://deluge-torrent.org/downloads/python-libtorrent_0.4.0.tar.gz (md5sum coincides) respectively (use %{name}, %{version}). * Please fix the permission included in -debuginfo rpm. Other things are okay. ------------------------------------------------------- This package (python-libtorrent) is APPROVED by me. I've fixed those in 0.4.0-2, which is what I will import into CVS. Spec: http://thecodergeek.com/downloads/fedora/python-libtorrent.spec SRPM: http://thecodergeek.com/downloads/fedora/python-libtorrent-0.4.0-2.src.rpm Thanks for your review! |