Bug 2214051

Summary: tracefs/tracefs.h: #include <event-parse.h> should be #include <traceevent/event-parse.h>
Product: Red Hat Enterprise Linux 9 Reporter: Taketo Kabe <rkabe>
Component: libtracefsAssignee: Michael Petlan <mpetlan>
Status: ASSIGNED --- QA Contact: Qiao Zhao <qzhao>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 9.2CC: acme, jkacur, zsun
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: All   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Taketo Kabe 2023-06-11 11:51:55 UTC
Description of problem:
#include <tracefs/tracefs.h> errors out on sub #include <event-parse.h> . 


Version-Release number of selected component (if applicable):
RHEL 9.2
libtracefs-devel-1.3.1-1.el9
libtraceevent-devel-1.5.3-3.el9 (dependency)

How reproducible:
always

Steps to Reproduce:

Prepare tracefs.c:
==========
#include <tracefs/tracefs.h>
==========
(yes, only 1 line)

$ cc -c tracefs.c


Actual results:
In file included from tracefs.c:2:
/usr/include/tracefs/tracefs.h:11:10: fatal error: event-parse.h: No such file or directory
   11 | #include <event-parse.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.


Expected results:
No error

Additional info:
This came evident when compiling custom kernel and compiling tools/tracing/rtls/ tree failed.

In /usr/include/tracefs/tracefs.c,
#include <event-parse.h> seems to be should be #include <traceevent/event-parse.h> .
Please disregard if I was wrong.

Comment 1 Michael Petlan 2023-06-22 15:48:34 UTC
Reproduced. Seems that you're right. However, upstream suffers from the same, so we'll discuss it upstream.

Comment 2 Michael Petlan 2023-07-14 10:10:50 UTC
Steven Rostedt does not consider this a bug:

==============================================================================
The pkgconfig for libtraceevent has:

 $ pkgconf --cflags libtraceevent
-I/usr/local/include/traceevent

Where it should include the path that includes "traceevent", as you should
not need to add it specifically.
==============================================================================

Using pkgconfig, the compilation should pass.