Bug 2214063

- rpmlint checks return:

xorg-x11-xdm.x86_64: E: incorrect-fsf-address /etc/X11/xdm/Xsetup_0
xorg-x11-xdm.x86_64: E: executable-marked-as-config-file /etc/X11/xdm/Xreset
xorg-x11-xdm.x86_64: E: executable-marked-as-config-file /etc/X11/xdm/Xsetup_0
xorg-x11-xdm.x86_64: E: executable-marked-as-config-file /etc/X11/xdm/Xstartup
xorg-x11-xdm.x86_64: E: executable-marked-as-config-file /etc/X11/xdm/Xwilling
xorg-x11-xdm.x86_64: W: empty-%postun
xorg-x11-xdm.x86_64: W: dangling-relative-symlink /etc/X11/xdm/Xsession ../xinit/Xsession
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/X11/xdm/Xaccess
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/X11/xdm/Xreset
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/X11/xdm/Xresources
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/X11/xdm/Xservers
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/X11/xdm/Xsetup_0
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/X11/xdm/Xstartup
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/X11/xdm/Xwilling
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/X11/xdm/xdm-config
xorg-x11-xdm.x86_64: W: conffile-without-noreplace-flag /etc/pam.d/xdm
xorg-x11-xdm.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/bin/xdm
xorg-x11-xdm.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/libexec/chooser

If memory serves these are all OK but make sure.

+ package meets naming guidelines
+ package meets packaging guidelines
- license (MIT) OK, text in %doc, matches source
   Move COPYING from %doc to %license
+ spec file legible, in am. english
+ source matches upstream
+ package compiles on devel (x86)
+ no missing BR
+ no unnecessary BR
+ no locales
+ not relocatable
+ owns all directories that it creates
+ no duplicate files
+ permissions ok
+ %clean ok
+ macro use consistent
+ code, not content
+ no need for -docs
+ nothing in %doc affects runtime
+ no need for .desktop file

Hi @gwync,
Thank you for your review.

SPEC: https://github.com/alissonbrunosa/xorg-x11-xdm/blob/main/xorg-x11-xdm.spec
SRPMs:
  - [Fedora 37](https://download.copr.fedorainfracloud.org/results/alissonbruno/xorg-x11-xdm/fedora-37-x86_64/06072750-xorg-x11-xdm/xorg-x11-xdm-1.1.14-29.fc37.src.rpm)
  - [Fedora 38](https://download.copr.fedorainfracloud.org/results/alissonbruno/xorg-x11-xdm/fedora-38-x86_64/06072750-xorg-x11-xdm/xorg-x11-xdm-1.1.14-29.fc38.src.rpm)
  - [EPEL 7](https://download.copr.fedorainfracloud.org/results/alissonbruno/xorg-x11-xdm/epel-7-x86_64/06072750-xorg-x11-xdm/xorg-x11-xdm-1.1.14-29.el7.src.rpm)
  - [EPEL 8](https://download.copr.fedorainfracloud.org/results/alissonbruno/xorg-x11-xdm/epel-8-x86_64/06072750-xorg-x11-xdm/xorg-x11-xdm-1.1.14-29.el8.src.rpm)
  - [EPEL 9](https://download.copr.fedorainfracloud.org/results/alissonbruno/xorg-x11-xdm/epel-9-x86_64/06072750-xorg-x11-xdm/xorg-x11-xdm-1.1.14-29.el9.src.rpm)
  

I've fixed most of the rpmlint issue.
The only ones left are: 

xorg-x11-xdm.x86_64: W: empty-%postun

xdm depends on xorg-x11-xinit, which provides the linked file
xorg-x11-xdm.x86_64: W: dangling-relative-symlink /etc/X11/xdm/Xsession ../xinit/Xsession 

Can't really do anything here, the xdm binary uses gethostbyname, to fix it I would have to fix it in the source.
xorg-x11-xdm.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/bin/xdm 
xorg-x11-xdm.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/libexec/chooser 


[OK] package meets naming guidelines
[OK] package meets packaging guidelines
[FIXED] license (MIT) OK, text in %doc, matches source. Move COPYING from %doc to %license
[OK] spec file legible, in am. english
[OK] source matches upstream
[OK] package compiles on devel (x86)
[OK] no missing BR
[OK] no unnecessary BR
[OK] no locales
[OK] not relocatable
[OK] owns all directories that it creates
[OK] no duplicate files
[OK] permissions ok
[OK] %clean ok
[OK] macro use consistent
[OK] code, not content
[OK] no need for -docs
[OK] nothing in %doc affects runtime
[OK] no need for .desktop file

Excellent! APPROVED. I've sponsored you into the Pacakger group.

Awesome and thank you.
Should I close the ticket?

Once the latest version is imported and built in at least rawhide. You're very welcome!

Hi Gwyn,
I can see the groups I am in on Fedora Accounts, but on pagure I have no groups.
Perhaps, it takes some time to sync between them services?

As I am unsure if I am lacking permission due to the missing groups on pagure to
push to rawhide directly, I have created a Pull Request instead. 

I've taken some screenshots, please check this link: https://imgur.com/a/qrgcedO

(In reply to Alisson Bruno from comment #6)
> Hi Gwyn,
> I can see the groups I am in on Fedora Accounts, but on pagure I have no
> groups.
> Perhaps, it takes some time to sync between them services?

Assuming you mean the pagure instance at src.fedoraproject.org (and not pagure.io), then all you need to do to sync your account is to log out and log back in.
The instance at pagure.io only uses the same login system, but is not directly associated with the Fedora account system / groups / etc.

(In reply to Fabio Valentini from comment #7)
> (In reply to Alisson Bruno from comment #6)
> > Hi Gwyn,
> > I can see the groups I am in on Fedora Accounts, but on pagure I have no
> > groups.
> > Perhaps, it takes some time to sync between them services?
> 
> Assuming you mean the pagure instance at src.fedoraproject.org (and not
> pagure.io), then all you need to do to sync your account is to log out and
> log back in.
> The instance at pagure.io only uses the same login system, but is not
> directly associated with the Fedora account system / groups / etc.

That worked. Thank you Fabio.

Package is now in repositories, closing review.