Bug 2214331

Summary:	Simplified ACS update fails to remove products if product has any empty URL repos
Product:	Red Hat Satellite	Reporter:	Ian Ballou <iballou>
Component:	Alternate Content Sources	Assignee:	Samir Jha <sajha>
Status:	CLOSED ERRATA	QA Contact:	Vladimír Sedmík <vsedmik>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.13.0	CC:	vsedmik
Target Milestone:	6.15.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-04-23 17:11:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ian Ballou 2023-06-12 16:30:43 UTC

Steps tp reproduce:
Create a product.
Create a yum repository with URL, sync and everything you'd do normally.
Create another yum repo without a URL.

Create a simplified ACS and add the product to it.
Try removing that product from the ACS. It fails.

<pre>
undefined method `smart_proxy_id' for nil:NilClass (NoMethodError)
/usr/share/gems/gems/katello-4.7.0.23/app/lib/actions/pulp3/alternate_content_source/delete.rb:6:in `plan'
</pre>

We probably need to test presence of smart_proxy_acs before planning Pulp3::Orchestration::AlternateContentSource::Delete here: https://github.com/Katello/katello/blob/449e319762f962c33dafd8b123f3f7f1d9feb1f5/app/lib/actions/katello/alternate_content_source/update.rb#L74

Comment 1 Ian Ballou 2023-06-12 16:30:47 UTC

Created from redmine issue https://projects.theforeman.org/issues/36221

Comment 2 Ian Ballou 2023-06-12 16:30:48 UTC

Upstream bug assigned to None

Comment 3 Ian Ballou 2023-06-12 16:32:41 UTC

This is not a regression. It's a bug from when simplified ACSs were introduced. It's not very likely that a user will hit the bug -- they'd have to have a custom repository that later has its upstream URL removed.

Comment 5 Brad Buckingham 2023-06-15 14:25:03 UTC

Should this be on ACS vs Subscription Management?

Comment 6 Ian Ballou 2023-06-20 13:33:19 UTC

I moved it to ACS, looks like redmine to bugzilla sync has a bug

Comment 7 Bryan Kearney 2023-07-06 12:03:05 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/36221 has been resolved.

Comment 8 Brad Buckingham 2023-10-30 11:29:29 UTC

Bulk setting Target Milestone = 6.15.0 where sat-6.15.0+ is set.

Comment 9 Vladimír Sedmík 2024-01-23 11:18:13 UTC

Reproduced in 6.14.2 snap 1, verified in 6.15.0 snap 7.0 - product with combined repos (with and without url) can be added and removed from the Simplified ACS without errors. Also, if the upstream url is removed from the repository later, the containing product is removed from the ACS automatically.

Comment 12 errata-xmlrpc 2024-04-23 17:11:25 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.15.0 release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:2010