Bug 2214331

Summary:	Simplified ACS update fails to remove products if product has any empty URL repos
Product:	Red Hat Satellite	Reporter:	Ian Ballou <iballou>
Component:	Alternate Content Sources	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	POST ---	QA Contact:	Satellite QE Team <sat-qe-bz-list>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.13.0	Keywords:	Triaged
Target Milestone:	Unspecified
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ian Ballou 2023-06-12 16:30:43 UTC

Steps tp reproduce:
Create a product.
Create a yum repository with URL, sync and everything you'd do normally.
Create another yum repo without a URL.

Create a simplified ACS and add the product to it.
Try removing that product from the ACS. It fails.

<pre>
undefined method `smart_proxy_id' for nil:NilClass (NoMethodError)
/usr/share/gems/gems/katello-4.7.0.23/app/lib/actions/pulp3/alternate_content_source/delete.rb:6:in `plan'
</pre>

We probably need to test presence of smart_proxy_acs before planning Pulp3::Orchestration::AlternateContentSource::Delete here: https://github.com/Katello/katello/blob/449e319762f962c33dafd8b123f3f7f1d9feb1f5/app/lib/actions/katello/alternate_content_source/update.rb#L74

Comment 1 Ian Ballou 2023-06-12 16:30:47 UTC

Created from redmine issue https://projects.theforeman.org/issues/36221

Comment 2 Ian Ballou 2023-06-12 16:30:48 UTC

Upstream bug assigned to None

Comment 3 Ian Ballou 2023-06-12 16:32:41 UTC

This is not a regression. It's a bug from when simplified ACSs were introduced. It's not very likely that a user will hit the bug -- they'd have to have a custom repository that later has its upstream URL removed.

Comment 5 Brad Buckingham 2023-06-15 14:25:03 UTC

Should this be on ACS vs Subscription Management?

Comment 6 Ian Ballou 2023-06-20 13:33:19 UTC

I moved it to ACS, looks like redmine to bugzilla sync has a bug

Comment 7 Bryan Kearney 2023-07-06 12:03:05 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/36221 has been resolved.