Bug 2214398

Summary: callgrind_control produces (strict perl) errors
Product: Red Hat Enterprise Linux 8 Reporter: Mark Wielaard <mjw>
Component: valgrindAssignee: Mark Wielaard <mjw>
valgrind sub component: system-version QA Contact: Jesus Checa <jchecahi>
Status: VERIFIED --- Docs Contact:
Severity: unspecified    
Priority: unspecified CC: fweimer, jakub, ohudlick, qe-baseos-tools-bugs
Version: 8.9Keywords: Triaged
Target Milestone: rc   
Target Release: 8.9   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: valgrind-3.21.0-7.el8 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: 2214397 Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2214397    
Bug Blocks:    
Deadline: 2023-07-03   

Description Mark Wielaard 2023-06-12 20:36:53 UTC 
+++ This bug was initially created as a clone of Bug #2214397 +++

The perl script were made to use strict; but the callgrind_control script is not correct perl strict. Causing:

$ callgrind_control --help
Global symbol "@pids" requires explicit package name (did you forget to declare "my @pids"?) at /usr/bin/callgrind_control line 35.
Global symbol "$vgdbPrefixOption" requires explicit package name (did you forget to declare "my $vgdbPrefixOption"?) at /usr/bin/callgrind_control line 36.
Global symbol "$pid" requires explicit package name (did you forget to declare "my $pid"?) at /usr/bin/callgrind_control line 39.
[...]

Upstream fixed this by rewriting the script. I like to simply remove the use strict; line to get back to the known working version. Already done in Fedora.