Bug 2214431

Summary: Review Request: rust-prometheus-client - Open Metrics client library allowing users to natively instrument applications
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Michel Alexandre Salim <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-08-05 21:17:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2214434    
Bug Blocks:    

Description Fabio Valentini 2023-06-13 01:09:04 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-prometheus-client.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-prometheus-client-0.19.0-1.fc38.src.rpm

Description:
Open Metrics client library allowing users to natively instrument
applications.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-06-13 01:18:56 UTC
COPR build:
https://copr.fedorainfracloud.org/coprs/decathorpe/ntpd-rs/build/6067360/

Comment 2 Michel Alexandre Salim 2023-08-04 22:32:13 UTC
Note: 0.21.2 is out, consider importing this instead

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged
- license matches upstream specification (Apache-2.0 OR MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 3 Fabio Valentini 2023-08-05 20:09:55 UTC
Thanks for the review! Will update as soon as possible.

Comment 4 Fedora Admin user for bugzilla script actions 2023-08-05 20:10:14 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-prometheus-client