Bug 2215780

Summary:	Broken links to sources in scala-apidoc
Product:	[Fedora] Fedora	Reporter:	Alex Zolotko <azolotko>
Component:	scala	Assignee:	Jerry James <loganjerry>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	38	CC:	azolotko, loganjerry, mizdebsk
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	scala-2.13.11-1.fc39~bootstrap	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-06-30 19:57:12 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Alex Zolotko 2023-06-18 16:36:34 UTC

Description of problem:

scala.spec contains the following line at https://src.fedoraproject.org/rpms/scala/blob/rawhide/f/scala.spec#_203:

SCALADOC_FLAGS='-J-Xmx512M -J-Xms32M -doc-footer epfl -diagrams -implicits -groups -doc-version %{version} -doc-source-url https://github.com/scala/scala/tree/${versionProperties.value.githubTree}€{FILE_PATH_EXT}#L€{FILE_LINE}'


Unfortunately, ${versionProperties.value.githubTree} is not being substituted and gets rendered into the resulting HTMLs literally, as is.


Steps to Reproduce:

$ sudo dnf install scala-apidoc-2.13.10-2.fc38.noarch 

$ grep github -r /usr/share/doc/scala-apidoc
...
/usr/share/doc/scala-apidoc/compiler/scala/tools/nsc/tasty/bridge/NameOps.html:...<dt>Source</dt><dd><a href="https://github.com/scala/scala/tree/${versionProperties.value.githubTree}compiler/scala/tools/nsc/tasty/bridge/NameOps.scala#L22" target="_blank">NameOps.scala</a></dd></dl>...


Additional info:

This blocks update to Scala 2.13.11, because in Scala 2.13.11, -doc-source-url is expected to be a valid URI and all scaladoc invocations with such SCALADOC_FLAGS will fail.

Comment 1 Jerry James 2023-06-29 21:30:33 UTC

I had two packages that depended on scala.  I removed the scala dependency from one a couple of months ago.  I am about to push a build for the other that removes its dependency on scala.  Hence I am no longer interested in scala.  I intend to orphan it and related packages next week.  (For the record, the full list is scala, scalacheck, java-diff-utils, jline, jol, juniversalchardet, and material-icons-fonts.)

If you or any other interested party wants to take these packages, let me know and I will transfer ownership.  I will make a similar announcement on fedora-devel-list in a few days.

Comment 2 Fedora Update System 2023-06-30 19:54:10 UTC

FEDORA-2023-52fa8ceb24 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-52fa8ceb24

Comment 3 Fedora Update System 2023-06-30 19:57:12 UTC

FEDORA-2023-52fa8ceb24 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 4 Jerry James 2023-06-30 19:57:52 UTC

I had a change of heart.  I am updating the scala package to 2.13.11 and fixing this bug, *then* orphaning it next week.  That way, if somebody wants to take it over, they don't have to fix a bug right away.