Bug 2215910

Summary: [UI] Error message improvements. Block pool Edit label checks failed.
Product: [Red Hat Storage] Red Hat OpenShift Data Foundation Reporter: Daniel Osypenko <dosypenk>
Component: management-consoleAssignee: Sanjal Katiyar <skatiyar>
Status: CLOSED ERRATA QA Contact: Daniel Osypenko <dosypenk>
Severity: low Docs Contact:
Priority: unspecified    
Version: 4.13CC: ebenahar, odf-bz-bot, skatiyar, tdesala, vbadrina
Target Milestone: ---   
Target Release: ODF 4.16.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 4.16.0-86 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-17 13:11:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Daniel Osypenko 2023-06-19 11:09:30 UTC
Description of problem (please be detailed as possible and provide log
snippests):
Two problems where found on validation "Edit Block Pool label" 

1. When passing consequent dots (..) no warnings appear. https://drive.google.com/file/d/1TOhZ3NCHegLR4QMoBmYCL91a-kWggLty/view?usp=sharing

2. When passing invalid label name and have warning message you still can click on save https://drive.google.com/file/d/1PHsTXYkK5fSOb7KVpnhU4BHlOVDWAf1S/view?usp=sharing. User gets wrong impression that label was saved.
But when user passing invalid label that violates rule, that first or last symbol should be alphanumeric - user can not save such label. We need to make straight behavior on invalid label. From UX point the popup should not allow to save such label and close the Edit label popup when clicking Save.

Version of all relevant components (if applicable):
OC version:
Client Version: 4.12.0-202208031327
Kustomize Version: v4.5.4
Server Version: 4.13.0-0.nightly-2023-06-12-231643
Kubernetes Version: v1.26.5+7d22122

OCS verison:
ocs-operator.v4.13.0-rhodf              OpenShift Container Storage   4.13.0-rhodf   ocs-operator.v4.12.4-rhodf              Succeeded

Cluster version
NAME      VERSION                              AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.13.0-0.nightly-2023-06-12-231643   True        False         16h     Cluster version is 4.13.0-0.nightly-2023-06-12-231643

Rook version:
rook: v4.12.4-0.bc1e9806c3281090b58872e303e947ff5437c078
go: go1.18.10

Ceph version:
ceph version 16.2.10-172.el8cp (00a157ecd158911ece116ae43095de793ed9f389) pacific (stable)


Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?
no

Is there any workaround available to the best of your knowledge?
no

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?
1

Can this issue reproducible?
yes, every time

Can this issue reproduce from the UI?
yes

If this is a regression, please provide more details to justify this:
not a regression

Steps to Reproduce:
1. Login to management console and navigate to StorageSystems/ StorageSystem details
2. Click on Block Pool tab and edit any of the Block Pools which is not a default ocs-storagecluster-cephblockpool
3.a Type label with name "app=front.....end" - warning should appear, user cannot save
3.b Type label with name "app=front&&&&label" - warning should appear, user cannot save, popup don't close when user click on Save
 

Actual results:
"app=front.....end" - warning does not appear
"app=front&&&&label" - user can click on Save, popup close when user click on Save

Expected results:
"app=front.....end" - warning appear
"app=front&&&&label" - user can not Save, Edit Label popup do not disappear on clicking Save. Popup disappear when user clicks Cancel or correct the label to one which is allowed to Save. Similarly to the input "app=."

Additional info:
screen recording links referred in description

Comment 2 Sanjal Katiyar 2023-07-19 17:52:06 UTC
need to check how label selector is working at other places in OCP/ODF, if functionality is same everywhere we can CLOSE this bug else need to fix it... adding conditional ack for now as it is of low severity and can be moved out to next release...

Comment 8 Sanjal Katiyar 2024-04-23 10:49:48 UTC
added basic validation and made it almost similar to how OCP handles this for pages like PVC, StorageClass etc.

"app=front.....end" >> this is valid case and we should not see any warning here.

"app=front&&&&label" >> for examples like these, we should see warning with "Save" button disabled.

for any other case which is not-handled/missed by UI, K8s API server will handle that and reject the label add/patch request. We should be seeing an error in this case on the "Edit labels" modal itself.

Comment 14 Daniel Osypenko 2024-04-30 14:08:39 UTC
4.16.0-90.stable
Verified, see attachment

Comment 16 errata-xmlrpc 2024-07-17 13:11:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.16.0 security, enhancement & bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:4591