Bug 2216055

Summary:	DNF5 documented option --skip-broken throws a syntax error
Product:	[Fedora] Fedora	Reporter:	Ian Laurie <ian.laurie>
Component:	dnf5	Assignee:	rpm-software-management
Status:	NEW ---	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	39	CC:	alekcejk, jkolarik, mblaha, mmalik, nsella, pkratoch, psplicha, rpm-software-management
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ian Laurie 2023-06-19 23:37:32 UTC

The man page for DNF5 in Rawhide shows --skip-broken to be a legal generic option, however it does not show up in a "dnf --help" and in practice its use results in this error:

Unknown argument "--skip-broken" for command "dnf5". Add "--help" for more information about the arguments. 

Reproducible: Always

Steps to Reproduce:
1. Launch DNF5 using the --skip-broken option.
2.
3.
Actual Results:  
Throws an error.

Expected Results:  
Documented option should work.

Considering that --help doesn't show the --skip-broken option this is probably a bug in the man page rather than DNF5.

Even if the option is useless in the current version of DNF, it may be a good idea to support it in DNF5, and simply ignore it, to maintain compatibility with existing automation scripts.

The man page also does not document the available legacy DNF compatibility options (for example --enablerepo for --enable-repo).

Comment 1 Marek Blaha 2023-06-20 06:02:04 UTC

Sorry, this is indeed a mistake in dnf5 man pages. The `--skip-broken` and `--skip-unavailable` options are not general for any command, but are implemented only for some dnf5 commands - currently distrosync, downgrade, group install, group upgrade, install, and reinstall.

Comment 2 Milos Malik 2023-06-23 10:59:25 UTC

Observation:

# dnf --skip-broken install filesystem
Unknown argument "--skip-broken" for command "dnf5". Add "--help" for more information about the arguments.
# dnf install --skip-broken filesystem
...
works as expected

Comment 3 Ian Laurie 2023-06-25 01:27:28 UTC

As suggested by my original report, and confirmed by Comment #1, the "bug" is in the man page, not in the operation of dnf.

Comment 4 nucleo 2023-07-13 14:37:49 UTC

Should --skip-broken with upgrade?

# dnf5 --skip-broken upgrade
Unknown argument "--skip-broken" for command "dnf5". Add "--help" for more information about the arguments.
# dnf5 upgrade --skip-broken
Unknown argument "--skip-broken" for command "upgrade". Add "--help" for more information about the arguments.

Comment 5 Fedora Release Engineering 2023-08-16 08:15:22 UTC

This bug appears to have been reported against 'rawhide' during the Fedora Linux 39 development cycle.
Changing version to 39.