Bug 2216299

I read the reason for disabling the tests - it would be relatively straightforward to add back the path-based dependency on gix-testtools as a normal version-based dependency (an example where I do this for an existing crate is rust-futures: https://src.fedoraproject.org/rpms/rust-futures/blob/rawhide/f/futures-fix-metadata.diff ).

However, it looks like most of the tests are indeed excluded from published crates (probably they are in a separate "tests/" directory?), so I agree that just disabling tests is the more rational choice here.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
! test suite is run and all unit tests pass (tests are disabled, reason documented)
! latest version of the crate is packaged (v0.22.0 was released)
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

===

Package will be APPROVED if you say that bumping to v0.22.0 would cause additional work for other pending reviews. In that case, importing v0.21 now and updating to v0.22 later is fine with me. Otherwise, please update to the latest version.

> Package will be APPROVED if you say that bumping to v0.22.0 would cause additional work for other pending reviews. In that case, importing v0.21 now and updating to v0.22 later is fine with me. Otherwise, please update to the latest version.

I will update to the latest version as soon as gix-date v0.6.0 lands in rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=102542741)

Updated `gix-actor` to the latest version. Here are the new URLs:

Spec URL: https://blinxen.fedorapeople.org/rust-gix-actor/rust-gix-actor.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-gix-actor/rust-gix-actor-0.23.0-1.fc39.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6138355
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2216299-rust-gix-actor/fedora-rawhide-x86_64/06138355-rust-gix-actor/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Whoops, sorry, I must have missed the last update.
Please remove the "document-features" dependency and subpackage, it's not installable.

There's also apparently a conflict with gix-features:

Error: 
 Problem 1: conflicting requests
  - nothing provides (crate(document-features/default) >= 0.2.0 with crate(document-features/default) < 0.3.0~) needed by rust-gix-actor+document-features-devel-0.23.0-1.fc39.noarch
 Problem 2: conflicting requests
  - nothing provides (crate(gix-features/default) >= 0.31.0 with crate(gix-features/default) < 0.32.0~) needed by rust-gix-actor+gix-features-devel-0.23.0-1.fc39.noarch

Updated `gix-actors` to the latest version and removed the documentation feature.

Spec URL: https://blinxen.fedorapeople.org/rust-gix-actor/rust-gix-actor.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-gix-actor/rust-gix-actor-0.24.0-1.fc39.src.rpm


This review is blocked by https://bugzilla.redhat.com/show_bug.cgi?id=2219456. So until that is fixed, this review cannot continue.

Created attachment 1976739 [details]
The .spec file difference from Copr build 6138355 to 6191187

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6191187
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2216299-rust-gix-actor/fedora-rawhide-x86_64/06191187-rust-gix-actor/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

This currently doesn't install - it needs gix-features v0.32.

 Problem: conflicting requests
  - nothing provides (crate(gix-features/default) >= 0.32.0 with crate(gix-features/default) < 0.33.0~) needed by rust-gix-actor+gix-features-devel-0.24.0-1.fc39.noarch

gix-features was updated to v0.32.1, unblocking this review.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Version 0.24.1 has been released in the meantime, please update the package as soon as possible (before or after importing the current version).

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gix-actor

FEDORA-2023-5389718910 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5389718910

FEDORA-2023-5389718910 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.