Bug 2216300

Summary:	Review Request: rust-gix-features - To integrate various capabilities using compile-time feature flags
Product:	[Fedora] Fedora	Reporter:	blinxen <h-k-81>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-06-28 21:42:40 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description blinxen 2023-06-20 19:13:00 UTC

Spec URL: https://blinxen.fedorapeople.org/rust-gix-features/rust-gix-features.spec
SRPM URL: https://blinxen.fedorapeople.org/rust-gix-features/rust-gix-features-0.30.0-1.fc39.src.rpm
Description: A crate to integrate various capabilities using compile-time feature
flags.
Fedora Account System Username: blinxen

Comment 1 Fabio Valentini 2023-06-27 23:35:44 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass (there are no tests)
! latest version of the crate is packaged
- license matches upstream specification (MIT/Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Three minor issues:

- Please improve the summary / description, it's rather meaningless right now. Upstream might appreciate an improvement as well. :)
- Upstream has released v0.31.0 since this was filed, but I'll approve v0.30.0 right now since v0.31.0 adds a dependency on gix-tracing which is not packaged yet. Just update once possible / once gix-tracing is available.
- No tests are run at all, it looks like they are all gated behind feature flags. You might want to add the "-a" flag to all %cargo_*" macros to enable them.

Comment 2 Fedora Admin user for bugzilla script actions 2023-06-28 20:47:41 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gix-features

Comment 3 blinxen 2023-06-28 20:53:26 UTC

> Please improve the summary / description, it's rather meaningless right now. Upstream might appreciate an improvement as well. :)

I will try to come up with something better.

> Upstream has released v0.31.0 since this was filed, but I'll approve v0.30.0 right now since v0.31.0 adds a dependency on gix-tracing which is not packaged yet. Just update once possible / once gix-tracing is available.

Will update once gix-trace is in rawhide.

> No tests are run at all, it looks like they are all gated behind feature flags. You might want to add the "-a" flag to all %cargo_*" macros to enable them.

Did not notice this, good catch!

Comment 4 blinxen 2023-06-28 21:42:40 UTC

Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-0b9f62302f