Bug 2216561

Summary:	Review Request: golang-github-maxatome-testdeep - Tests HTTP APIs and provides tests suite
Product:	[Fedora] Fedora	Reporter:	Mikel Olasagasti Uranga <mikel>
Component:	Package Review	Assignee:	Link Dupont <link>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	link, package-review
Target Milestone:	---	Flags:	link: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-06-30 15:00:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1963568

Description Mikel Olasagasti Uranga 2023-06-21 20:45:35 UTC

Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-maxatome-testdeep.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-maxatome-testdeep-1.13.0-1.fc38.src.rpm
Description: tests HTTP APIs and provides tests suite.
Fedora Account System Username: mikelo2

Comment 1 Link Dupont 2023-06-30 13:53:21 UTC

> %gometa

> # REMOVE BEFORE SUBMITTING THIS FOR REVIEW
> # ---
> # New Fedora packages should use %%gometa -f, which makes the package
> # ExclusiveArch to %%golang_arches_future and thus excludes the package from
> # %%ix86. If the new package is needed as a dependency for another package,
> # please consider removing that package from %%ix86 in the same way, instead of
> # building more go packages for i686. If your package is not a leaf package,
> # you'll need to coordinate the removal of the package's dependents first.
> # ---
> # REMOVE BEFORE SUBMITTING THIS FOR REVIEW

Could we instead update golang-github-jarcoal-httpmock to use `%gometa -f` to drop its i686 version?

Comment 2 Link Dupont 2023-06-30 14:14:22 UTC

- [x] The spec file is clear and easy to read
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No rpmlint errors (or valid justification for exceptions)
- [x] %check section passes
- [x] The latest version is packaged
- [x] %goipath is set correctly
- [x] The package complies with the Packaging Guidelines

Package approved, but consider updating golang-github-jarcoal-httpmock to use `%gometa -f` instead of introducing additional packages into i686 (I know this one is noarch only, but it introduces the possibility of dependent i686 packages in the future).

On import, don't forget to do the following:

- [ ] Add package to https://release-monitoring.org
- [ ] Add package to https://koschei.fedoraproject.org/packages
- [ ] Grant @go-sig group commit privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket.

Comment 3 Fedora Admin user for bugzilla script actions 2023-06-30 14:47:23 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-maxatome-testdeep

Comment 4 Fedora Update System 2023-06-30 14:59:52 UTC

FEDORA-2023-2f528de924 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-2f528de924

Comment 5 Fedora Update System 2023-06-30 15:00:09 UTC

FEDORA-2023-2f528de924 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.