Bug 2216667

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Gem package must not define a non-gem subpackage


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 1 files have unknown license. Detailed
     output of licensecheck in
     /home/FedoraPackaging/reviews/rubygem-test-unit-ruby-
     core/2216667-rubygem-test-unit-ruby-core/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
     independent under %{gem_dir}.
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).
[x]: Gem package does not contain Requires: ruby(release).

===== SHOULD items =====

Generic:
[!]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Ruby:
[!]: Specfile should use macros from rubygem-devel package.
     Note: The specfile doesn't use these macros: %exclude %{gem_cache}
[x]: Gem package should exclude cached Gem.
[x]: Gem should use %gem_install macro.
[x]: gems should not require rubygems package
[x]: Test suite should not be run by rake.
[x]: Test suite of the library should be run.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rubygem-test-unit-ruby-core-1.0.1-1.fc38.noarch.rpm
          rubygem-test-unit-ruby-core-doc-1.0.1-1.fc38.noarch.rpm
          rubygem-test-unit-ruby-core-1.0.1-1.fc38.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp60znjemn')]
checks: 31, packages: 3

rubygem-test-unit-ruby-core.spec: W: invalid-url Source1: test-unit-ruby-core-1.0.1-additional.tar.gz
 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 2.5 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 2

 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.0 s 



Source checksums
----------------
https://rubygems.org/gems/test-unit-ruby-core-1.0.1.gem :
  CHECKSUM(SHA256) this package     : 82ca19f043a285514d2262357df227996ef87ffde9cd7eaa3e87e7abe6bf13f1
  CHECKSUM(SHA256) upstream package : 82ca19f043a285514d2262357df227996ef87ffde9cd7eaa3e87e7abe6bf13f1


Requires
--------
rubygem-test-unit-ruby-core (rpmlib, GLIBC filtered):
    ruby(rubygems)

rubygem-test-unit-ruby-core-doc (rpmlib, GLIBC filtered):
    rubygem-test-unit-ruby-core



Provides
--------
rubygem-test-unit-ruby-core:
    rubygem(test-unit-ruby-core)
    rubygem-test-unit-ruby-core

rubygem-test-unit-ruby-core-doc:
    rubygem-test-unit-ruby-core-doc



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2216667 -m fedora-38-x86_64
Buildroot used: fedora-38-x86_64
Active plugins: Generic, Ruby, Shell-api
Disabled plugins: C/C++, R, Ocaml, Python, SugarActivity, Java, PHP, Perl, Haskell, fonts
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comments:
a) In the spec file should
# Source1 is created by $ bash %%SOURCE1 %%version
be
# Source1 is created by $ bash %%SOURCE2 %%version
or
# Source1 is created by $ bash test-unit-ruby-core-create-missing-files.sh %%version
b) Maybe ri files can be put with the main package as they do not have javascript and font files?  Just a suggestion.
 A separate docs package is also ok, though maybe an update is needed to allow for separate documentation packages in gem packages?

For now, I will leave doc subpacakge separataion as it is.

https://download.copr.fedorainfracloud.org/results/mtasaka/for_package_review/fedora-rawhide-x86_64/06148871-rubygem-test-unit-ruby-core/
https://download.copr.fedorainfracloud.org/results/mtasaka/for_package_review/fedora-rawhide-x86_64/06148871-rubygem-test-unit-ruby-core/rubygem-test-unit-ruby-core-1.0.1-2.fc39.src.rpm

* Fri Jul  7 2023 Mamoru TASAKA <mtasaka> - 1.0.1-2
- Fix comment for source

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6148911
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2216667-rubygem-test-unit-ruby-core/fedora-rawhide-x86_64/06148911-rubygem-test-unit-ruby-core/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Thanks. Approved.

Review of https://bugzilla.redhat.com/show_bug.cgi?id=213896
would be appreciated if time allows.

Thank you for review!

By the way, while I am not sure if I can make time, the bug entry you posted seems unrelated to Package Review
(component says old gnome-bluetooth).

Sorry, wrong link:
https://bugzilla.redhat.com/show_bug.cgi?id=2138969

The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-test-unit-ruby-core

Built on rawhide, thank you.