Bug 2216766

Summary: Make Toolbx a release-blocking deliverable and have release-blocking test criteria
Product: [Fedora] Fedora Reporter: Aoife Moloney <amoloney>
Component: Changes TrackingAssignee: Debarshi Ray <debarshir>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 39CC: awilliam, debarshir, kevin, sumukher, thrcka
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-11-14 18:57:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2242874, 2244503, 2245066    
Bug Blocks: 2158243    

Description Aoife Moloney 2023-06-22 13:37:30 UTC
This is a tracking bug for Change: Make Toolbx a release-blocking deliverable and have release-blocking test criteria
For more details, see: https://fedoraproject.org/wiki/Changes/ToolbxReleaseBlocker

Up to date fedora-toolbox OCI images must be published on registry.fedoraproject.org as release-blocking deliverables, and there must be release-blocking test criteria to ensure usable toolbox RPMs.

If you encounter a bug related to this Change, please do not comment here. Instead create a new bug and set it to block this bug.

Comment 1 Adam Williamson 2023-08-22 08:12:46 UTC
so, best as I can tell: the pungi-fedora change is merged, but toolbox is *not* currently marked as fatal (i.e. it *is* marked as 'failable'). in today's compose, it succeeded on aarch64 and x86_64 but failed on s390x and ppc64le: https://koji.fedoraproject.org/koji/taskinfo?taskID=105067291

the release criterion has been added: https://fedoraproject.org/wiki/Fedora_39_Beta_Release_Criteria#Toolbx_Functionality . we haven't yet added a wiki test case, I don't think. An openQA test is under review: https://pagure.io/fedora-qa/os-autoinst-distri-fedora/pull-request/293

on the whole, I guess this adds up to MODIFIED...

Comment 2 sumantro 2023-08-22 08:19:35 UTC
(In reply to Adam Williamson from comment #1)
> so, best as I can tell: the pungi-fedora change is merged, but toolbox is
> *not* currently marked as fatal (i.e. it *is* marked as 'failable'). in
> today's compose, it succeeded on aarch64 and x86_64 but failed on s390x and
> ppc64le: https://koji.fedoraproject.org/koji/taskinfo?taskID=105067291
> 
> the release criterion has been added:
> https://fedoraproject.org/wiki/
> Fedora_39_Beta_Release_Criteria#Toolbx_Functionality . we haven't yet added
> a wiki test case, I don't think. An openQA test is under review:
> https://pagure.io/fedora-qa/os-autoinst-distri-fedora/pull-request/293
> 
> on the whole, I guess this adds up to MODIFIED...

The wiki test case has always been there https://fedoraproject.org/wiki/QA:Testcase_toolbox

Comment 3 Adam Williamson 2023-08-22 08:27:00 UTC
Oh, good. We should probably add it to some validation matrix and category, though (base, I guess?)

Comment 4 sumantro 2023-08-22 12:55:35 UTC
(In reply to Adam Williamson from comment #3)
> Oh, good. We should probably add it to some validation matrix and category,
> though (base, I guess?)

Sure, I agree. Can you point me to the template matrix? or do I edit the Base of a "current" validation image?
I would call it [[Category:Container_Management]]

Comment 5 Adam Williamson 2023-08-23 00:20:43 UTC
There are existing categories loosely associated with the matrices. I'd add it to https://fedoraproject.org/wiki/Template:Base_test_matrix and put it in category Base_Acceptance_Test_Cases . Please send a draft to the ML or something for review, as editing the matrices is sensitive...thanks!

Comment 6 Kevin Fenzi 2023-08-28 18:02:45 UTC
FYI, I have merged the failable '' changes...

Comment 7 Adam Williamson 2023-09-21 18:54:38 UTC
The wiki change has been made, the openQA test was merged - I don't think we hooked up reporting yet, but I can do that easily today. I think this is good enough to call it ON_QA , unless anyone disagrees.

Comment 8 Adam Williamson 2023-09-21 18:55:24 UTC
Correction - actually we *did* hook up the wiki reporting, so openQA is already reporting results for the test.

Comment 9 Debarshi Ray 2023-11-06 15:21:12 UTC
We did find a bunch of regressions at the last minute during the Fedora 39 Final Freeze:
https://bugzilla.redhat.com/show_bug.cgi?id=2242874
https://bugzilla.redhat.com/show_bug.cgi?id=2244503
https://bugzilla.redhat.com/show_bug.cgi?id=2245066

... but, fortunately, they all got fixed.

So, I suppose we are all set here for tomorrow Fedora 39 release?

Comment 10 Aoife Moloney 2023-11-14 18:57:27 UTC
F39 was released on November 7th, so I am closing this tracker. If this Change was not completed, please notify me ASAP.