Bug 221677
Summary: | Review Request: atmel-firmware - Firmware for Atmel at76c50x wireless network chips | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nicolas Chauvet (kwizart) <kwizart> |
Component: | Package Review | Assignee: | Bill Nottingham <notting> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | katzj, notting, rvokal |
Target Milestone: | --- | Flags: | katzj:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-08-27 00:07:39 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Nicolas Chauvet (kwizart)
2007-01-05 23:42:10 UTC
Review: MUST - Package content is acceptable - *** Waiting on driver acceptance. Aside from that, OK. MUST - Package name follows guidelines - OK MUST - Spec file name is %{name}.spec - OK MUST - Package follows Packaging Guidelines - *** Description: 'another' isn't really right. %install - see notes under 'rpmlint output' section below. Source: Please use a full URL to the berlios download URL. MUST - BuildRoot is OK - OK MUST - License is OK - OK MUST - License is properly tagged - *** Per firmware packaging guidelines, should be: License: Redistributable, no modification permitted MUST - License is included in package - OK MUST - Spec is in english, and legible - OK MUST - Sources match upstream - OK MUST - Package builds - OK MUST - Package has proper arch settings - OK MUST - Package has proper BuildRequires - OK MUST - Package handles locales properly - N/A MUST - Package has proper %post scriplets for ldconfig - N/A MUST - Package owns proper directories - N/A MUST - Does not own directories it shouldn't - OK MUST - Package is relocatable if necessary - N/A MUST - Package has no duplicate files - N/A MUST - Package has proper file permissions - N/A MUST - Package has %clean - OK MUST - Package uses macros consistently - OK MUST - Package uses -doc, if needed - N/A MUST - Headers in -devel, if needed - N/A MUST - Static libs in -static - N/A MUST - Uses pkgconfig correctly - N/A MUST - Packages .so correctly - N/A MUST - Subpackages have proper Requires: - N/A MUST - Handles libtool correctly - N/A MUST - Uses .desktop, if necessary - N/A SHOULD - Package includes license as file - OK SHOULD - Builds in mock - OK SHOULD - Package functions - Can't test (no hardware) SHOULD - Scriptlets are sane - N/A SHOULD - File dependencies are sane - N/A rpmlint output: Source: E: at76_usb-firmware hardcoded-library-path in /lib/firmware/${i}.at76_usb E: at76_usb-firmware hardcoded-library-path in $RPM_BUILD_ROOT/lib/firmware E: at76_usb-firmware hardcoded-library-path in $RPM_BUILD_ROOT/lib/firmware E: at76_usb-firmware hardcoded-library-path in $RPM_BUILD_ROOT/lib/firmware E: at76_usb-firmware hardcoded-library-path in /lib/firmware/* OK for firmware. W: at76_usb-firmware macro-in-%changelog doc Please fix, use %%doc in %changelog. E: at76_usb-firmware no-cleaning-of-buildroot %install You need 'rm -rf $RPM_BUILD_ROOT' at the start of %install. Binary: W: at76_usb-firmware symlink-should-be-relative /usr/share/doc/at76_usb-firmware-0.1/README /lib/firmware/README.at76_usb W: at76_usb-firmware symlink-should-be-relative /usr/share/doc/at76_usb-firmware-0.1/COPYRIGHT /lib/firmware/COPYRIGHT.at76_usb This is OK. Please correct the above, and it should then be OK, pending driver acceptance. This is a new version: atmel-firmware 1.3 bundle both pci and usb firmwares. but at76_usb-firmware 0.1 update the firmware images for usb to curent 0.14beta1 Only the pci version is bundled inside the kernel. Usb version may need to be patched for theses version to work So i have bundled both pci and updated usb firmware images... From this patch "official website" http://atmelwlandriver.sourceforge.net/downloads.html there is a need to patch the kernel to allow usb devices to work... But i wonder if it will work since the patch don't seem to get updated for a while... I do not own an atmel chipset (neither pci no usb). But i've made an external kernel module that work fine (this was asked on the fedora-fr.org forum and reported to work for at least two persons) The kmod are build from this source: (version 0.14beta1) http://developer.berlios.de/projects/at76c503a/ This chipset seems not to be so common.... SRPMS: http://kwizart.free.fr/fedora/6/testing/at76_usb/atmel-firmware-1.3-1.kwizart.fc6.src.rpm SPECS: http://kwizart.free.fr/fedora/6/testing/at76_usb/atmel-firmware.spec Summary: Firmware for Atmel at76c50x wireless network chips Is anyone actually reviewing this package? fedora-review is set to '?' but it's blocking FE-NEW and isn't assigned to anyone. notting, it looks like you set the flag; did you intend to take this package? I'm still not sure what's going on here, but I'l at least clear the FE-NEW blocker. It looks like notting didn't see my past comment because he's not cc'd on the ticket. I generally avoid CCing others on tickets but in this case I guess I have to. So, notting, you set fedora-review and made some comments, but never assigned yourself or CC'd yourself on this ticket, so it dropped off of the new ticket list but received no further review commentary. Did you want to finish reviewing it? I'll take it, but I might not get to it for a few days. The at76_usb driver is now in rawhide. In fact, this message brought to you by it, with the firmware from kwizart's rebuilt src.rpm package. Good news ! i will drop the at76_usb kmod soon then! Thx for this feedback linville! I'm know waiting for reviewer advice (i will probably drop the dist tag, which is not relevant for firmwares... ) Bill's out on vacation and wrapping this up for test2 would be good. All of Bill's comments have been addressed and a quick check over stuff myself also looks sane. So approved. Leaving dist tag or not I leave up to you; it doesn't really make a big difference either way. Thanks for the review! I will remove the dist tag and build for F-7 so it will be available into the rawhide repository without a fc7 tag... I can do EPEL's later if needed... New Package CVS Request ======================= Package Name: atmel-firmware Short Description: Firmware for Atmel at76c50x wireless network chips Owners: kwizart / kwizart Branches: F-7 devel InitialCC: <empty> Commits by cvsextras: yes cvs done. |