Bug 2216826

Summary: failure in rocr::core::Runtime::LoadTools()
Product: [Fedora] Fedora Reporter: Philipp K. <philipp-dev>
Component: rocm-runtimeAssignee: Jeremy Newton <alexjnewt>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 38CC: alexjnewt, tstellar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rocm-runtime-5.5.0-2.fc39 rocm-runtime-5.4.4-2.el9 rocm-runtime-5.4.4-1.fc37 rocm-runtime-5.5.0-2.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-06-24 19:39:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Philipp K. 2023-06-22 19:20:09 UTC
Description of problem:
Fortifying the source triggers an assertion, which is not present in upstream ROCM binary distribution.
For me it fails with
> /usr/include/c++/13/bits/stl_vector.h:1123: std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::operator[](size_type) [with _Tp = const char*; _Alloc = std::allocator<const char*>; reference = const char*&; size_type = long unsigned int]: Assertion '__n < this->size()' failed.

Arch has had the same issue with the rocm-runtime: https://github.com/RadeonOpenCompute/ROCR-Runtime/issues/153

The github issue also includes a one-line patch. According to the issue this will be fixed in ROCM 5.6

Version-Release number of selected component (if applicable):
ROCM 5.5

How reproducible:
For me this is triggered by a pytorch nightly, but pruning this of the shipped "libhsa-runtime64.so" and using the fedora provided one

Steps to Reproduce:
1.
2.
3.

Actual results:
SIGABRT

Expected results:
no SIGABRT

Additional info:

Comment 1 Jeremy Newton 2023-06-23 22:18:08 UTC
Thanks for the report, I'll pull in the patch to Fedora.

Comment 2 Fedora Update System 2023-06-24 19:37:24 UTC
FEDORA-2023-7d6b8696b7 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-7d6b8696b7

Comment 3 Fedora Update System 2023-06-24 19:39:06 UTC
FEDORA-2023-7d6b8696b7 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 4 Fedora Update System 2023-06-24 20:37:39 UTC
FEDORA-EPEL-2023-d567d3b597 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-d567d3b597

Comment 5 Fedora Update System 2023-06-24 20:37:39 UTC
FEDORA-2023-0f6a638e82 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0f6a638e82

Comment 6 Fedora Update System 2023-06-24 20:37:40 UTC
FEDORA-2023-666acf7dcf has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-666acf7dcf

Comment 7 Jeremy Newton 2023-06-24 20:38:20 UTC
I fixed it in RAWHIDE, but backported it to the other branches.

Comment 8 Fedora Update System 2023-06-25 01:33:25 UTC
FEDORA-EPEL-2023-d567d3b597 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-d567d3b597

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2023-06-25 01:42:15 UTC
FEDORA-2023-0f6a638e82 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-0f6a638e82`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-0f6a638e82

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-06-25 01:46:41 UTC
FEDORA-2023-666acf7dcf has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-666acf7dcf`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-666acf7dcf

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-07-03 00:31:06 UTC
FEDORA-EPEL-2023-d567d3b597 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2023-07-03 00:34:25 UTC
FEDORA-2023-666acf7dcf has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2023-07-03 01:28:33 UTC
FEDORA-2023-0f6a638e82 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.