Bug 2217024

Summary: Review Request: rust-value-bag-serde1 - Implementation detail for value-bag
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-07-18 22:54:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2217023    
Bug Blocks: 2182546    

Description Fabio Valentini 2023-06-23 15:36:55 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-value-bag-serde1.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-value-bag-serde1-1.4.0-1.fc38.src.rpm

Description:
Implementation detail for value-bag.

Fedora Account System Username: decathorpe

Comment 3 Michel Lind 2023-07-18 22:36:18 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0 OR MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Fabio Valentini 2023-07-18 22:40:35 UTC
Thanks for the review!

Comment 5 Fedora Admin user for bugzilla script actions 2023-07-18 22:40:56 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-value-bag-serde1

Comment 6 Fabio Valentini 2023-07-18 22:54:09 UTC
Imported and built in f39-build-side-69808:
https://koji.fedoraproject.org/koji/buildinfo?buildID=2234675