Bug 2217186

Summary:	Review Request: rust-gix-trace - Minimal tracing support for gitoxide that can be turned off to zero cost
Product:	[Fedora] Fedora	Reporter:	blinxen <h-k-81>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-07-03 20:24:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2216739

Description blinxen 2023-06-24 23:05:29 UTC

Spec URL: https://blinxen.fedorapeople.org/phase1/rust-gix-trace.spec
SRPM URL: https://blinxen.fedorapeople.org/phase1/rust-gix-trace-0.1.1-1.fc39.src.rpm
Description: A crate to provide minimal `tracing` support that can be turned off to
zero cost.
Fedora Account System Username: blinxen

Comment 1 Fabio Valentini 2023-06-27 23:47:51 UTC

The rust-gix-trace+document-features-devel subpackage is not installable, since the document-features crate is not packaged for Fedora.
Please remove this optional feature. It is only used upstream / on docs.rs when building documentation, which we don't do for Rust crates.

Other than that, package looks good to me.

Comment 2 blinxen 2023-06-28 16:10:38 UTC

I updated the files and also made the summary more user friendly.

Comment 3 Fabio Valentini 2023-07-03 19:44:18 UTC

Thanks, looks good to me now. Sorry for the delay, I somehow missed the email notification for your last update.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Fedora Admin user for bugzilla script actions 2023-07-03 19:52:44 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gix-trace

Comment 5 blinxen 2023-07-03 20:24:41 UTC

Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a61761c7b9