Bug 2217200

Summary:	Finance quotes stopped working
Product:	[Fedora] Fedora	Reporter:	Jerry James <loganjerry>
Component:	gnucash	Assignee:	Gwyn Ciesla <gwync>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	38	CC:	gwync, paul, perl-devel
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	gnucash-5.2-2.fc38	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-06-29 01:25:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jerry James 2023-06-25 01:54:33 UTC

I have not been able to get market quotes using Finance::Quote recently.  If I open Tools -> Security Editor and look at one of the affected securities, the dialog contains this:

Quote Source Information
Warning: Finance::Quote not installed properly

If I run finance-quote-wrapper manually, this is printed:

You need to install the following Perl modules:
  JSON::Parse

Please see https://wiki.gnucash.org/wiki/Online_Quotes#Finance::Quote for detailed corrective action.
missing-lib

So it appears that either gnucash or perl-Finance-Quote is missing a Requires on perl-JSON-Parse.  Installing it manually results in being able to download quotes again.

Reproducible: Always

Steps to Reproduce:
1. Install gnucash on a system without perl-JSON-Parse installed
2. Note that installation of gnucash does not cause perl-JSON-Parse to be installed
3. Try to download finance quotes
Actual Results:  
The quotes are not downloaded successfully.  The error message does not mention perl-JSON-Parse, making this more difficult to debug than necessary.

Expected Results:  
Gnucash should install all necessary dependencies to get finance quotes.

Comment 1 Fedora Update System 2023-06-26 15:23:00 UTC

FEDORA-2023-5393a699c2 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5393a699c2

Comment 2 Fedora Update System 2023-06-26 15:23:00 UTC

FEDORA-2023-a78d3470d0 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a78d3470d0

Comment 3 Paul Howarth 2023-06-26 17:47:30 UTC

The JSON::Parse dependency has been added in the wrong place - Finance::Quote does not require it in any way.

The gnucash quote retrieval problem comes from finance-quote-wrapper itself, which requires JSON::Parse and Getopt::Std in addition to Finance::Quote.

Hence, dependencies on JSON::Parse and Getopt::Std should be added to gnucash rather than perl-Finance-Quote.

Comment 4 Gwyn Ciesla 2023-06-26 18:58:52 UTC

Thank you, I'll correct this.

Comment 5 Fedora Update System 2023-06-26 21:07:45 UTC

FEDORA-2023-e884cc3f99 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e884cc3f99

Comment 6 Fedora Update System 2023-06-27 10:55:32 UTC

FEDORA-2023-e884cc3f99 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e884cc3f99`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e884cc3f99

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2023-06-29 01:25:14 UTC

FEDORA-2023-e884cc3f99 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.