Bug 2217793

Summary: cinder::scheduler::filter class is not called anywhere.
Product: Red Hat OpenStack Reporter: Keigo Noha <knoha>
Component: puppet-tripleoAssignee: Cinder Bugs List <cinder-bugs>
Status: NEW --- QA Contact: Evelina Shames <eshames>
Severity: medium Docs Contact:
Priority: low    
Version: 17.0 (Wallaby)CC: abishop, eharney, jjoyce, jschluet, slinaber, tkajinam, tvignaud
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2222869    

Description Keigo Noha 2023-06-27 06:08:12 UTC 
Description of problem:
puppet-cinder has a class, cinder::scheduler::filter class.
However, the class is not included in puppet-cinder and puppet-tripleo.

Due to that, a user who wants to set the scheduler filter via puppet cannot configure the value to the relevant option

Version-Release number of selected component (if applicable):
OSP17.0 and upstream.

How reproducible:
Everytime when overcloud deploy is run.

Expected results:
The assigned values to the parameters in cinder::scheduler::filter are configured.

Actual results:
The assigned values to the parameters in cinder::scheduler::filter are not configured.


Additional info:
Currently, the user can configure the parameter via cinder_config.
Comment 1 Keigo Noha 2023-07-06 01:28:56 UTC 
Hi DFG:Storage team,

Do you have any updates on this bugzilla?

Best regards,
Keigo Noha
Comment 2 Eric Harney 2023-07-11 12:14:38 UTC 
Which Cinder options are they wanting to set that can't be set currently?
Comment 3 Alan Bishop 2023-07-11 14:02:29 UTC 
The cinder::scheduler::filter class supports a single parameter that configures cinder's scheduler_default_filters.

It's true the class isn't referenced anywhere, and could be added to puppet-tripleo. However, without a corresponding THT paramter, you're forced to use ExtraConfig to set the corresponding hiera data. It's a tradeoff between these approaches.

Current:
========

parameter_defaults:
  ControllerExtraConfig:
    cinder::config::cinder_config:
      DEFAULT/scheduler_default_filters:
        value: <list of scheduler default filters>

Proposed: [1]
=========
parameter_defaults:
  ControllerExtraConfig:
    cinder::scheduler::filter::scheduler_default_filters: <list of scheduler default filters>

[1] If we update puppet_tripleo to include the cinder::scheduler::filter class
Comment 4 Keigo Noha 2023-07-12 04:14:48 UTC 
Hi Eric,

I think Alan already replied to your question, the class provides a single interface, scheduler_driver[1].

[1] https://github.com/openstack/puppet-cinder/blob/master/manifests/scheduler.pp

Currently, we have a workaround which uses cinder_config. So, it is not urgent issue but is should be fixed.

Best regards,
Keigo Noha