Bug 2217973

Summary: Review Request: rust-maybe-rayon - Either acts as rayon or creates a single-threaded facade
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Davide Cavalca <davide>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: davide, package-review
Target Milestone: ---Flags: davide: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/maybe-rayon
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-06-28 19:42:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2149770    

Description Fabio Valentini 2023-06-27 17:59:12 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-maybe-rayon.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-maybe-rayon-0.1.1-1.fc38.src.rpm

Description:
Either acts as rayon or creates a single-threaded facade.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-06-27 17:59:15 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=102671561

Comment 2 Fedora Review Service 2023-06-27 18:05:31 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6119221
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2217973-rust-maybe-rayon/fedora-rawhide-x86_64/06119221-rust-maybe-rayon/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Davide Cavalca 2023-06-28 10:31:00 UTC
Taking this review

Comment 4 Davide Cavalca 2023-06-28 10:39:44 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 5 Fabio Valentini 2023-06-28 16:14:34 UTC
Thanks for the review!

Comment 6 Fedora Admin user for bugzilla script actions 2023-06-28 16:14:43 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-maybe-rayon

Comment 7 Fedora Update System 2023-06-28 18:10:57 UTC
FEDORA-2023-a96f1a1b2f has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a96f1a1b2f

Comment 8 Fedora Update System 2023-06-28 19:42:29 UTC
FEDORA-2023-a96f1a1b2f has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.