Bug 2217974

Summary:	Review Request: rust-av1-grain - Helpers for generating and parsing AV1 film grain data
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Davide Cavalca <davide>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	davide, package-review
Target Milestone:	---	Flags:	davide: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://crates.io/crates/av1-grain
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-06-28 19:42:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2132091
Bug Blocks:	2149770

Description Fabio Valentini 2023-06-27 18:00:34 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-av1-grain.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-av1-grain-0.2.2-1.fc38.src.rpm

Description:
Helpers for generating and parsing AV1 film grain data.

Fedora Account System Username: decathorpe

Comment 1 Fedora Review Service 2023-06-27 18:04:23 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6119229
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2217974-rust-av1-grain/fedora-rawhide-x86_64/06119229-rust-av1-grain/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-06-27 19:01:34 UTC

COPR build: https://copr.fedorainfracloud.org/coprs/decathorpe/rav1e-0.6.6/build/6119218/

Comment 3 Davide Cavalca 2023-06-28 10:40:23 UTC

Taking this review

Comment 4 Davide Cavalca 2023-06-28 10:44:52 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 5 Fabio Valentini 2023-06-28 16:14:38 UTC

Thanks for the review!

Comment 6 Fedora Admin user for bugzilla script actions 2023-06-28 16:15:00 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-av1-grain

Comment 7 Fedora Update System 2023-06-28 18:11:00 UTC

FEDORA-2023-a96f1a1b2f has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a96f1a1b2f

Comment 8 Fedora Update System 2023-06-28 19:42:32 UTC

FEDORA-2023-a96f1a1b2f has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.