Bug 2218116

Summary:	Avoid wrong detection of disk media type, such as HDD instead of SSD on vSAN
Product:	[Red Hat Storage] Red Hat OpenShift Data Foundation	Reporter:	Elad <ebenahar>
Component:	ocs-operator	Assignee:	Malay Kumar parida <mparida>
Status:	POST ---	QA Contact:	Aman Agrawal <amagrawa>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.13	CC:	amagrawa, mparida, muagarwa, odf-bz-bot, sapillai, srai, vavuthu
Target Milestone:	---	Flags:	amagrawa: needinfo? (ebenahar)
Target Release:	ODF 4.14.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Elad 2023-06-28 08:34:10 UTC

Description of problem (please be detailed as possible and provide log
snippets):

In some situations, such as vSphere VSAN, the drive media type is detected wrongly, for instance as HDD instead of SSD. For that, it would be good if we can set Set bluestore_debug_enforce_settings = "ssd" in rook-config-override

Comment 1 Mudit Agarwal 2023-06-28 10:37:08 UTC

I guess this should go to ocs-operator as we need to set it there. 
Malay, can you pick it up?

Comment 2 Mudit Agarwal 2023-06-28 10:37:31 UTC

More context: https://bugzilla.redhat.com/show_bug.cgi?id=2154351#c47

Comment 3 Subham Rai 2023-06-28 12:25:09 UTC

I think we should be able to set `Set bluestore_debug_enforce_settings = "ssd" ` it now as well, but I'll check and update here.

Comment 4 Malay Kumar parida 2023-06-30 06:47:48 UTC

Hi @sapillai , Can you take a look once? Is this related to your feature epic you are working for 4.14 https://github.com/red-hat-storage/ocs-operator/pull/2053.

Comment 6 Malay Kumar parida 2023-08-05 14:09:31 UTC

I was looking at this comment https://bugzilla.redhat.com/show_bug.cgi?id=2154351#c41 from the linked BZ.

```
RECOMMENDATION
Force BlueStore to use settings designed for SSDs.

1) set
bluestore_debug_enforce_settings = "ssd"
but it requires restart

OR

2) set 
bluestore_prefer_deferred_size_hdd = 0
should work right away and no new deferred writes will be enqueued
```

I see the 2nd option will not require OSD restarts. So shouldn't we set that one instead of the 1st one? I see in the linked BZ Aman went ahead with testing with the 2nd option.
In the case of customers who will upgrade from earlier versions of ODF will the 1st settings work as intended directly or it will require an osd restart?

Comment 7 Malay Kumar parida 2023-08-05 14:10:44 UTC

Also does the setting need to go under the global section or any other specific section?
ref-https://github.com/red-hat-storage/ocs-operator/blob/abe61d1773697c03af99cae0095d3136f252fa7c/controllers/storagecluster/cephconfig.go#L31

Comment 8 Elad 2023-08-06 07:13:42 UTC

(In reply to Malay Kumar parida from comment #6)

> I see the 2nd option will not require OSD restarts. So shouldn't we set that
> one instead of the 1st one? I see in the linked BZ Aman went ahead with
> testing with the 2nd option.

If the second option is the one we validated and it doesn't require OSD restart then we should go with it.

Comment 9 Aman Agrawal 2023-08-06 17:36:22 UTC

(In reply to Elad from comment #8)
> (In reply to Malay Kumar parida from comment #6)
> 
> > I see the 2nd option will not require OSD restarts. So shouldn't we set that
> > one instead of the 1st one? I see in the linked BZ Aman went ahead with
> > testing with the 2nd option.
> 
> If the second option is the one we validated and it doesn't require OSD
> restart then we should go with it.

This config. was tested only once. Elad, do you think a thorough testing is required here by perf. team or even us to validate the results?
Ref- https://bugzilla.redhat.com/show_bug.cgi?id=2154351#c49