Bug 2218267

Summary: [RHEL8]python38:3.8/python38: python38-pip: Python tarfile extraction needs change to avoid a warning (CVE-2007-4559 mitigation)
Product: Red Hat Enterprise Linux 8 Reporter: Charalampos Stratakis <cstratak>
Component: python3x-pipAssignee: Petr Viktorin <pviktori>
Status: VERIFIED --- QA Contact: Lukáš Zachar <lzachar>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.9CC: cstratak, pviktori, python-maint, rhel-cs-apps-subsystem-qe
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python38-3.8-8090020230810143931.d9f72c26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 2207997
: 2218275 (view as bug list) Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 263261    
Bug Blocks:    

Comment 1 Charalampos Stratakis 2023-08-09 23:42:02 UTC 
PR: https://gitlab.com/redhat/centos-stream/rpms/python3x-pip/-/merge_requests/4/diffs
Comment 2 Charalampos Stratakis 2023-08-09 23:45:54 UTC 
Verified through the PR with:

"""
import tarfile

def mkinfo(name, **kwargs):
    tarinfo = tarfile.TarInfo(name=name)
    for name, value in kwargs.items():
        setattr(tarinfo, name, value)
    return tarinfo

with tarfile.open('evil.tar.gz', 'w:gz') as tf:
    tf.addfile(mkinfo('./pyproject.toml'))
    tf.addfile(mkinfo('./tmp', type=tarfile.SYMTYPE,
                      linkname='../../../../../../../../tmp'))
    tf.addfile(mkinfo('./tmp/poc'))
"""

And then run python3.9 -m pip install evil.tar.gz

On an unpatched pip the evil.tar.gz will install successfully.

On a fixed/patched one a "tarfile.OutsideDestinationError: 'tmp/poc' would be extracted to '/tmp/poc', which is outside the destination" will appear.