Bug 2218307

Summary:	Upgrade rake task will create bad content overrides on post-6.14.0 Satellite upgrades
Product:	Red Hat Satellite	Reporter:	Jeremy Lenz <jlenz>
Component:	Hosts - Content	Assignee:	Partha Aji <paji>
Status:	CLOSED ERRATA	QA Contact:	Lukas Pramuk <lpramuk>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.14.0	CC:	lpramuk, pcreech, rlavi
Target Milestone:	6.14.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rubygem-katello-4.9.0.6-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-11-08 14:19:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeremy Lenz 2023-06-28 17:39:58 UTC

1. I perform a *new install* of Satellite 6.14.0. The upgrade tasks never run, since it's a new install. Default product enablement is disabled.
2. I then upgrade to 6.14.1 or 6.15. The upgrade task's `last_run_time` is `nil`, so it will be included in `UpgradeTask.needing_run` and override all of my custom repos to Enabled. This is not desired or appropriate.

https://community.theforeman.org/t/katello-4-9-custom-products-changes-with-sca/33763/10

Comment 1 Jeremy Lenz 2023-06-28 17:40:01 UTC

Created from redmine issue https://projects.theforeman.org/issues/36540

Comment 2 Jeremy Lenz 2023-06-28 17:40:03 UTC

Upstream bug assigned to None

Comment 3 Bryan Kearney 2023-07-12 00:03:17 UTC

Upstream bug assigned to paji

Comment 4 Bryan Kearney 2023-07-12 00:03:19 UTC

Upstream bug assigned to paji

Comment 5 Bryan Kearney 2023-07-19 20:03:58 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/36540 has been resolved.

Comment 9 Lukas Pramuk 2023-08-16 11:11:13 UTC

VERIFIED.

@Satellite 6.14.0 Snap10
rubygem-katello-4.9.0.9-1.el8sat.noarch

using the manual reproducer:

1) Install 6.14.0 Snap 8

2) Create custom product with custom repo  

3) Check AK overrides:
Disabled

4) Upgrade using 6.14.z scenario (illusory upgrade - no new content present, still migrations are being run)

5) Check AK overrides:
Enabled (overridden) 

>>> reproduced - content overrides were changed

6) Remove changed content overrides to get back to default AK overrides:
Disabled

7) Enable Snap 10 repos and upgrade using 6.14.z scenario (Snap8 -> Snap11)

8) Check AK overrides:
Disabled

>>> when upgrading across 6.14.z no further content overrides migration is performed

Comment 12 errata-xmlrpc 2023-11-08 14:19:51 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.14 security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6818