Bug 2218519

Summary:	[FFU] No PCI passthrough configration on computes after upgrade
Product:	Red Hat OpenStack	Reporter:	Ricardo Diaz <rdiazcam>
Component:	openstack-tripleo-heat-templates	Assignee:	Juan Badia Payno <jbadiapa>
Status:	CLOSED ERRATA	QA Contact:	Khomesh Thakre <kthakre>
Severity:	high	Docs Contact:
Priority:	high
Version:	17.1 (Wallaby)	CC:	ekuris, jbadiapa, jpretori, kthakre, mburns, pgrist, pnavarro
Target Milestone:	ga	Keywords:	Triaged, UpgradeBlocker
Target Release:	17.1
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	openstack-tripleo-heat-templates-14.3.1-1.20230519151017.el9ost	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-08-16 01:15:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2129048, 2129049, 2016660

Description Ricardo Diaz 2023-06-29 13:34:39 UTC

Description of problem:
There is no PCI passthrough configuration on computes after the upgrade. Found passthrough_whitelist not set /var/lib/config-data/puppet-generated/nova_libvirt/etc/nova/nova.conf:
~~~
#
# White list of PCI devices available to VMs. For more information, refer to the
# documentation. (multi valued)
# Deprecated group;name - DEFAULT;pci_passthrough_whitelist
#passthrough_whitelist =
~~~

The sriov-config.yaml provided:
~~~
[stack@undercloud-0 ~]$ cat ospd-16.2-vxlan-hw-offload-ctlplane-dataplane-bonding-hybrid/sriov-config.yaml 
---
parameter_defaults:
  ComputeSriovOffloadParameters:
    NovaPCIPassthrough:
      # Geneve/VxLAN configuration for Mellanox HW-Offload NIC
      - devname: "enp4s0f0"
        trusted: "true"
        physical_network: null
      # VLAN configuration for Mellanox HW-Offload NIC
      - devname: "enp4s0f1"
        trusted: "true"
        physical_network: mx-network

[stack@undercloud-0 ~]$ grep sriov-config.yaml overcloud_deploy.sh
-e /home/stack/ospd-16.2-vxlan-hw-offload-ctlplane-dataplane-bonding-hybrid/sriov-config.yaml \
~~~

According to sriov-config.yaml we should have the nova.conf file like this:
~~~
#
# White list of PCI devices available to VMs. For more information, refer to the
# documentation. (multi valued)
# Deprecated group;name - DEFAULT;pci_passthrough_whitelist
#passthrough_whitelist =
passthrough_whitelist={"devname":"enp4s0f0","physical_network":null,"trusted":"true"}
passthrough_whitelist={"devname":"enp4s0f1","physical_network":"mx-network","trusted":"true"}
~~~

Version-Release number of selected component (if applicable):
17.1 FFU

How reproducible:
100%

Steps to Reproduce:
1.Perform FFU
2.
3.

Actual results:

Expected results:

Additional info:

Comment 14 errata-xmlrpc 2023-08-16 01:15:51 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Release of components for Red Hat OpenStack Platform 17.1 (Wallaby)), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2023:4577