Bug 2219090

Summary:	Review Request: rust-cstr - Macro for building static CStr reference
Product:	[Fedora] Fedora	Reporter:	Kalev Lember <klember>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-07-02 21:15:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kalev Lember 2023-07-01 22:25:49 UTC

Spec URL: https://kalev.fedorapeople.org/rust-cstr.spec
SRPM URL: https://kalev.fedorapeople.org/rust-cstr-0.2.11-1.fc39.src.rpm
Description:
Macro for building static CStr reference.

Fedora Account System Username: kalev

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=102817197

Comment 1 Fabio Valentini 2023-07-02 17:24:38 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

I would be grateful if you could review one of my pending packages (maybe RHBZ#2214386) in return.

Comment 2 Kalev Lember 2023-07-02 19:27:50 UTC

Thanks for the super quick review, Fabio! I'll definitely review something in return.

Comment 3 Fedora Admin user for bugzilla script actions 2023-07-02 19:28:55 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cstr

Comment 4 Fedora Update System 2023-07-02 21:13:26 UTC

FEDORA-2023-d3e2853a09 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d3e2853a09

Comment 5 Fedora Update System 2023-07-02 21:15:16 UTC

FEDORA-2023-d3e2853a09 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.