Bug 2219447

Summary:	Installation not including imhex specific data files
Product:	[Fedora] Fedora	Reporter:	zeroaurora233
Component:	imhex	Assignee:	Jonathan Wright <jonathan>
Status:	CLOSED ERRATA	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	38	CC:	jonathan, rebus
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	imhex-1.30.1-3.fc39	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-07-03 20:54:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description zeroaurora233 2023-07-03 18:40:57 UTC

This package will not install anything under /usr/share/imhex, but the official package does. Files under this folder provide ImHex with hex pattern files which are helpful for viewing hex files.

Probably [this](https://github.com/WerWolv/ImHex/blob/d297b2d1ccd0e1c8841cd9cfe563717df827c135/.github/workflows/build.yml#L554) is the reason why the official build is different with the Fedora build. This line enables online build, allowing cmake to download pattern files during build.

If online build is not availiable in Fedora build infrastructure, a separate package (like imhex-patterns in other distros) as a weak dependency is desirable.

A current workaround is to download patterns in content store, but is not very convenient for new users.

Reproducible: Always

Comment 1 Jonathan Wright 2023-07-03 18:46:41 UTC

I work directly with upstream on this one and his desire at the time was to just have people download the latest definitions from the content store.  I'll reach out to him and see if this request might change his stance.

Comment 2 zeroaurora233 2023-07-03 19:18:46 UTC

Thanks for your information.

A little more about that: I submitted this bug report because one friend asked me about that, but I never experienced the problem with official packages (I use official AppImage). Since https://github.com/WerWolv/ImHex-Patterns already states that patterns will be bundled with releases, I hope that downstreams should also package them.

Comment 3 Jonathan Wright 2023-07-03 19:19:37 UTC

I'm working on an update right now to package them.

Comment 4 Fedora Update System 2023-07-03 20:53:28 UTC

FEDORA-2023-56c8768e6f has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-56c8768e6f

Comment 5 Fedora Update System 2023-07-03 20:54:08 UTC

FEDORA-2023-56c8768e6f has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 zeroaurora233 2023-07-04 04:49:18 UTC

Nice job! Thanks!