Bug 221947

rpmlint is not silent
rpmlint on main RPM reported
W: gwenhywfar non-conffile-in-etc /etc/gwen-public-ca.crt
A non-executable file in your package is being installed in /etc, but is not
a configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rpmlint on -devel rpm reported
I: gwenhywfar-devel checking
E: gwenhywfar-devel only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

Otherwise mock build is fine.

(In reply to comment #1)
> W: gwenhywfar non-conffile-in-etc /etc/gwen-public-ca.crt

It's not really a configuration file, it's a data file. It's a CA certificate
bundle, much like /etc/pki/tls/certs/ca-bundle.crt. However, that is
also marked %config, so I'll change this.

(Ideally it just uses the openssl CA bundle.)

> E: gwenhywfar-devel only-non-binary-in-usr-lib
> There are only non binary files in /usr/lib so they should be in /usr/share.

This is a mis-error from rpmlint. It's a architecture-specific include, so it
can't be in /usr/include, and needs to be in an architecture specific directory.
 See glib2, dbus, gcc, qt for other examples of this.

(In reply to comment #2)
> (In reply to comment #1)
> > W: gwenhywfar non-conffile-in-etc /etc/gwen-public-ca.crt
> 
> It's not really a configuration file, it's a data file. It's a CA certificate
> bundle, much like /etc/pki/tls/certs/ca-bundle.crt. However, that is
> also marked %config, so I'll change this.

Perhaps it should live in /etc/pki/tls/certs too?

It's not easily modifiable without patching, and if I'm going to do that, I'd
rather just patch it to *use* the openssl one. Currently discussing that w/upstream.

FWIW, curl uses the openssl one rather than the one shipped in the curl tarball...

2.3.0-6 uploaded; cert bundle marked as config, rpaths fixed.

Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM.
- rpmlint is NOT silent for RPMS.
E: gwenhywfar-devel only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.
But its ok as it looks mis-error by rpmlint.

+ source files match upstream.
0f7cf7d0efa6719f85c00d6d8ccec2b3  gwenhywfar-2.3.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code Not contents.
+ no static libraries present.
+ no gwenhywfar.pc files present.
+ -devel subpackage exists
+ included
  %post -p /sbin/ldconfig
  %postun -p /sbin/ldconfig
+ no .la files.
+ translations are available
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ no scriptlets used.
+ file permissions are appropriate.
APPROVED.

Just looking over:

(In reply to comment #7)
> + no gwenhywfar.pc files present.

It certainly has them in my builds...

(In reply to comment #8)
> Just looking over:
> 
> (In reply to comment #7)
> > + no gwenhywfar.pc files present.
> 
> It certainly has them in my builds...
oops Sorry. I actually used to copy my Review Template and modify them according
to package. I forgot to remove no word.

Ping
any problem for importing this package to CVS?

Just waiting for the round tuits. Will get to it this week-ish.

This is built now.

Package Change Request
======================
Package Name: gwenhywfar
New Branches: EL-4 EL-5

CVS done.