Bug 2219471
| Summary: | Review Request: rust-prodash - Dashboard for visualizing progress of asynchronous and possibly blocking tasks | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | blinxen <h-k-81> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | https://crates.io/crates/prodash | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-07-06 04:12:09 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
blinxen
2023-07-03 20:29:28 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=102890139 Copr build: https://copr.fedorainfracloud.org/coprs/build/6138349 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2219471-rust-prodash/fedora-rawhide-x86_64/06138349-rust-prodash/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Some of the subpackages fail to install due to missing dependencies: === Problem 1: conflicting requests - nothing provides (crate(compound_duration/default) >= 1.2.0 with crate(compound_duration/default) < 2.0.0~) needed by rust-prodash+compound_duration-devel-25.0.0-1.fc39.noarch Problem 2: conflicting requests - nothing provides (crate(crosstermion) >= 0.11.0 with crate(crosstermion) < 0.12.0~) needed by rust-prodash+crosstermion-devel-25.0.0-1.fc39.noarch Problem 3: conflicting requests - nothing provides (crate(human_format/default) >= 1.0.3 with crate(human_format/default) < 2.0.0~) needed by rust-prodash+human_format-devel-25.0.0-1.fc39.noarch Problem 4: conflicting requests - nothing provides (crate(crosstermion/crossterm) >= 0.11.0 with crate(crosstermion/crossterm) < 0.12.0~) needed by rust-prodash+render-line-crossterm-devel-25.0.0-1.fc39.noarch Problem 5: conflicting requests - nothing provides (crate(crosstermion/color) >= 0.11.0 with crate(crosstermion/color) < 0.12.0~) needed by rust-prodash+render-line-devel-25.0.0-1.fc39.noarch Problem 6: conflicting requests - nothing provides (crate(crosstermion/termion) >= 0.11.0 with crate(crosstermion/termion) < 0.12.0~) needed by rust-prodash+render-line-termion-devel-25.0.0-1.fc39.noarch Problem 7: conflicting requests - nothing provides (crate(crosstermion/input-async-crossterm) >= 0.11.0 with crate(crosstermion/input-async-crossterm) < 0.12.0~) needed by rust-prodash+render-tui-crossterm-devel-25.0.0-1.fc39.noarch - nothing provides (crate(crosstermion/tui-react-crossterm) >= 0.11.0 with crate(crosstermion/tui-react-crossterm) < 0.12.0~) needed by rust-prodash+render-tui-crossterm-devel-25.0.0-1.fc39.noarch Problem 8: conflicting requests - nothing provides (crate(crosstermion/input-async) >= 0.11.0 with crate(crosstermion/input-async) < 0.12.0~) needed by rust-prodash+render-tui-devel-25.0.0-1.fc39.noarch Problem 9: conflicting requests - nothing provides (crate(crosstermion/tui-react-termion) >= 0.11.0 with crate(crosstermion/tui-react-termion) < 0.12.0~) needed by rust-prodash+render-tui-termion-devel-25.0.0-1.fc39.noarch Problem 10: conflicting requests - nothing provides (crate(tui-react/default) >= 0.20.0 with crate(tui-react/default) < 0.21.0~) needed by rust-prodash+tui-react-devel-25.0.0-1.fc39.noarch Problem 11: package rust-prodash+unit-human-devel-25.0.0-1.fc39.noarch requires crate(prodash/human_format) = 25.0.0, but none of the providers can be installed - conflicting requests - nothing provides (crate(human_format/default) >= 1.0.3 with crate(human_format/default) < 2.0.0~) needed by rust-prodash+human_format-devel-25.0.0-1.fc39.noarch Problem 12: package rust-prodash+unit-duration-devel-25.0.0-1.fc39.noarch requires crate(prodash/compound_duration) = 25.0.0, but none of the providers can be installed - conflicting requests - nothing provides (crate(compound_duration/default) >= 1.2.0 with crate(compound_duration/default) < 2.0.0~) needed by rust-prodash+compound_duration-devel-25.0.0-1.fc39.noarch === I would recommend to remove features you don't need, and fix the rest. For example, I would drop crosstermion / tui / tui-react dependencies if possible - they frequently publish breaking releases, keeping up with them is quite painful. I deactivated all features which don't build / install. I kept the rest even though I don't need all features. `gix` only requires the `progress-tree` feature. Updated files can be found under: Spec URL: https://blinxen.fedorapeople.org/rust-prodash/rust-prodash.spec SRPM URL: https://blinxen.fedorapeople.org/rust-prodash/rust-prodash-25.0.0-1.fc39.src.rpm P.S I will review some of your packages later in return for reviewing my package reviews :D Created attachment 1974160 [details]
The .spec file difference from Copr build 6138349 to 6144146
Copr build: https://copr.fedorainfracloud.org/coprs/build/6144146 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2219471-rust-prodash/fedora-rawhide-x86_64/06144146-rust-prodash/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === It would be great if you added a comment in the spec file to describe what the patch does (something like "remove unused optional features with missing dependencies"). The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-prodash FEDORA-2023-4a0d885d08 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4a0d885d08 FEDORA-2023-4a0d885d08 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |