Bug 2219548

Summary: Missing license in the License field
Product: [Fedora] Fedora Reporter: Štěpán Horáček <shoracek>
Component: libtpmsAssignee: Stefan Berger <stefanb>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: davide, marcandre.lureau, stefanb
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: libtpms-0.9.6-2.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-07-22 01:22:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Štěpán Horáček 2023-07-04 09:21:07 UTC
The spec file's License field does not contain the Trusted Computing Group license, even though the license file does contain it.

Reproducible: Always

Steps to Reproduce:
1. List the licenses (e.g. by using `rpm -q libtpms --queryformat "%{license}\n"`).
Actual Results:  
BSD


Expected Results:  
BSD and TCGL

Comment 1 Štěpán Horáček 2023-07-04 09:30:10 UTC
There is a relevant GitLab issue for adding the license as allowed in Fedora: https://gitlab.com/fedora/legal/fedora-license-data/-/issues/24

Comment 2 Fedora Update System 2023-07-17 20:07:36 UTC
FEDORA-2023-18269425be has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-18269425be

Comment 3 Fedora Update System 2023-07-18 01:26:37 UTC
FEDORA-2023-18269425be has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-18269425be`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-18269425be

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 4 Stefan Berger 2023-07-19 12:08:24 UTC
We now have a package failure due to adding TCGL.

https://artifacts.dev.testing-farm.io/5f66f51f-52c9-47a0-9d16-a049edf88304/

Comment 5 Štěpán Horáček 2023-07-19 13:29:04 UTC
That's part of the problem. TCGL was removed from the list of allowed licenses since no package was known to use it. There is an issue in Fedora's license repository I linked earlier that should address this problem.

https://gitlab.com/fedora/legal/fedora-license-data/-/issues/24

Also, I think the expected output could be "BSD-3-Clause AND TCGL" instead to migrate it to the new SPDX format.

Comment 6 Stefan Berger 2023-07-19 15:27:07 UTC
So what do you suggest that I do now? Wait?

Comment 7 Fedora Update System 2023-07-22 01:22:01 UTC
FEDORA-2023-18269425be has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.