Bug 222083
| Summary: | USB spinlock recursion bug in acm_read_bulk | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert Hentosh <rhentosh> | ||||||
| Component: | kernel | Assignee: | Pete Zaitcev <zaitcev> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Brian Brock <bbrock> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 6 | CC: | davej, wtogami | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | i686 | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2007-09-07 23:49:34 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 237323 | ||||||||
| Attachments: |
|
||||||||
|
Description
Robert Hentosh
2007-01-10 03:45:07 UTC
Created attachment 145220 [details]
Full serial capture of failed system
Robert, I'm convinced that the failure is fixed in updated kernels for FC-6.
I have verified the 2.6.20-1.2923.fc6, and the change is plainly there.
Please re-test with an updated kernel and close the bug if the problem
is gone.
The 2.6.20 has this versus the 2.6.18:
next_buffer:
- spin_lock(&acm->read_lock);
+ spin_lock_irqsave(&acm->read_lock, flags);
if (list_empty(&acm->filled_read_bufs)) {
- spin_unlock(&acm->read_lock);
+ spin_unlock_irqrestore(&acm->read_lock, flags);
goto urbs;
}
Oooh, wait. I see what the problem is. The RHEL 5 has this problem, because it ships with 2.6.18. It's just the Bugzilla has product version set to fc6. Created attachment 149082 [details]
Candidate patch #1 (RHEL 5)
This is a small backport from Fedora, which should be sufficient.
I have verified that the fix is in 2.6.19-1.2911.6.4.fc6. Robert, please verify that it works and close the bug. I have also verified that the patch works on FC5 2.6.18-1.2239 and RHEL5 2.6.18-15.el5. Both patch cleanly. Both were tested heavily for a day. Would have expected around 8-10 failures in that time. Patch works. What about FC-6 though? Can we close the bug? BTW, I cloned this into bug 237323 for RHEL 5. Closing this as "in Rawhide", but actually I think F-7 has the fix too. |