Bug 2221357

Summary:	Review Request: rust-archery - Abstract over the atomicity of reference-counting pointers
Product:	[Fedora] Fedora	Reporter:	Mattia Verga <mattia.verga>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-07-08 12:00:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2179260, 2221358

Description Mattia Verga 2023-07-08 09:39:00 UTC

Spec URL: https://mattia.fedorapeople.org/rust-archery/rust-archery.spec
SRPM URL: https://mattia.fedorapeople.org/rust-archery/rust-archery-0.5.0-1.fc39.src.rpm
Description: Abstract over the atomicity of reference-counting pointers
Fedora Account System Username: mattia

Comment 1 Fabio Valentini 2023-07-08 09:51:25 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MPL-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Minor nit-pick: Please add a comment to the Patch in the spec file (something like "criterion dependency is used only for running benchmarks, which does not happen during package builds, tests that use compiletest_rs are not included in published sources, ...).

Hint for future Rust packages: I strongly recommend using rust2rpm's "-p" flag for patching Cargo.toml files. This happens so frequently that it's mostly automated. Also, some changes to Cargo.toml metadata will trigger changes to how the spec file is generated, so making these changes manually *after* the spec is already generated will lead to a spec file that is out of sync with the actual package contents. When using "rust2rpm -p", changes to Cargo.toml are taken into account when generating the spec file.

Hint number two: Use the "-s" flag for rust2rpm. It saves you from having to run "spectool -g" separately. :)

Welcome to Rust packaging! 😅

Comment 2 Fedora Admin user for bugzilla script actions 2023-07-08 11:48:33 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-archery

Comment 3 Fedora Update System 2023-07-08 12:00:15 UTC

FEDORA-2023-116d7f2bb7 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-116d7f2bb7

Comment 4 Fedora Update System 2023-07-08 12:00:54 UTC

FEDORA-2023-116d7f2bb7 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.