Bug 2221621

Summary:	katello-certs-check does not cause the installer to halt execution on failure
Product:	Red Hat Satellite	Reporter:	Ewoud Kohl van Wijngaarden <ekohlvan>
Component:	Installer	Assignee:	Ewoud Kohl van Wijngaarden <ekohlvan>
Status:	VERIFIED ---	QA Contact:	Radek Mynar <rmynar>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.13.3	CC:	ahumbe, jpathan, pcreech, rlavi
Target Milestone:	6.14.0	Keywords:	Regression, Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	foreman-installer-3.7.0.1-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ewoud Kohl van Wijngaarden 2023-07-10 10:42:57 UTC

Description of problem:

When using custom certificates the installer runs katello-certs-check to make sure the certificates are valid. A regression introduced in foreman-installer 3.4.0 caused it to continue execution after katello-certs-check has failed.

Version-Release number of selected component (if applicable):

foreman-installer 3.4.0 - 3.7.0

How reproducible:

Always

Steps to Reproduce:
1. Create certificates that fail katello-certs-check
2. Run the installer with those custom certificates

Actual results:

Installer shows the errors and continues

Expected results:

Installer halts after showing katello-certs-check errors

Comment 1 Bryan Kearney 2023-07-10 12:03:19 UTC

Upstream bug assigned to ekohlvan

Comment 2 Bryan Kearney 2023-07-10 12:03:20 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/36567 has been resolved.

Comment 4 Radek Mynar 2023-08-14 14:46:41 UTC

Installer halts with custom certificates that don't pass katello-certs-check. No harmful changes are applied to already configured Satellite (satellite-maintain health check reports all OK).

VERIFIED with Satellite 6.14 SNAP10 @RHEL8.8