Bug 2221673

Summary: hammer settings set returns incomplete message for False values
Product: Red Hat Satellite Reporter: Vladimír Sedmík <vsedmik>
Component: HammerAssignee: Oleh Fedorenko <ofedoren>
Status: POST --- QA Contact: Satellite QE Team <sat-qe-bz-list>
Severity: low Docs Contact:
Priority: unspecified    
Version: 6.14.0CC: ofedoren
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Vladimír Sedmík 2023-07-10 15:00:47 UTC 
Description of problem:
hammer settings set returns incomplete message when setting some boolean with False value.


Version-Release number of selected component (if applicable):
6.14.0 snap 6


How reproducible:
always


Steps to Reproduce:
1. Try to set some (no matter which) boolean setting to False:
# hammer settings set --name db_pending_seed --value 0


Actual results:
Setting [db_pending_seed] updated to [].


Expected results:
Setting [db_pending_seed] updated to [false].


Additional info:
Works fine for True values
# hammer settings set --name db_pending_seed --value False
Setting [db_pending_seed] updated to [].
# hammer settings set --name db_pending_seed --value false
Setting [db_pending_seed] updated to [].
# hammer settings set --name db_pending_seed --value 0
Setting [db_pending_seed] updated to [].

# hammer settings set --name db_pending_seed --value True
Setting [db_pending_seed] updated to [true].
# hammer settings set --name db_pending_seed --value true
Setting [db_pending_seed] updated to [true].
# hammer settings set --name db_pending_seed --value 1
Setting [db_pending_seed] updated to [true].
Comment 1 Vladimír Sedmík 2023-07-10 15:23:20 UTC 
No regression, reproduced in 6.13.2 snap 1
Comment 2 Oleh Fedorenko 2023-07-13 14:53:46 UTC 
Created redmine issue https://projects.theforeman.org/issues/36588 from this bug
Comment 3 Bryan Kearney 2023-08-07 20:03:07 UTC 
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/36588 has been resolved.