Bug 2221902
| Summary: | Edit icon needs to be standardized | ||
|---|---|---|---|
| Product: | Container Native Virtualization (CNV) | Reporter: | Avital Pinnick <apinnick> |
| Component: | User Experience | Assignee: | Tal Nisan <tnisan> |
| Status: | CLOSED WONTFIX | QA Contact: | Guohua Ouyang <gouyang> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.14.0 | CC: | gouyang, hstastna, yfrimanm |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-07-17 16:12:55 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
Hi Yifat, WDYT about this issue? Thanks! The only place it appears with the label is in the "Labels" section. In all other places only the pencil icon is shown. Anyway, this is a console behavior that was already discussed in the past. Maybe @gouyang can recall what was the explanation for it when it was raised last time. (In reply to Yifat Menchik from comment #3) > The only place it appears with the label is in the "Labels" section. In all > other places only the pencil icon is shown. Anyway, this is a console > behavior that was already discussed in the past. Maybe @gouyang > can recall what was the explanation for it when it was raised last time. The last time we fixed the issue is https://bugzilla.redhat.com/show_bug.cgi?id=2090042, which is about move the button close to the text. We also talked about the button for "Labels" in VM details tab, but it just aligns with OCP， so it's not using the same style like other buttons in VM details tab. This issue is about removing "Edit" label from the edit button in VM scripts tab, I agree removing it to make them looking consistently. Thank you @gouyang for your explanation. The attachment 1975105 [details] screen shot is not related to the Scripts tab, so it got me confused.
+1 to remove the "Edit" label from the edit button in VM scripts tab.
Hi folks, I'd like to ask a few questions: - and what about template's and "Review and create VirtualMachine" Scripts tabs? (see the attachments I've added) - are we fine with the fact that if we remove "Edit" label and leave the pencil icon there, it will be less visible for the user if the item is editable/not editable? - are we fine with the fact that in other places with only pencil icon, there's the specific editable value displayed using blue font color, while in Scripts tab achieving the same is problematic? Thanks in advance! I think @hstastna is right. I agree that if we remove "Edit" label and only have the pencil icon there, it will be less clear for the user to know the item is editable or not editable. If we keep this logic that in the places with only the pencil icon, we show a specific editable value in blue font color I think it's ok. WDYT? I'd leave this as it is and close this bug, as I think adding blue font color to the appropriate values and removing "Edit" in Scripts tab would not make the screens look better. We would have to change the behavior of how we edit each specific value, too, to make it work and be consistent with rest of the Ui. We would have to decide how to display those values, to have a specific modal for each value etc, which does not seem to me practical at all. Actually, we can change both the username and pwd in one modal. So IMO in these specific screens it is better to accept inconsistency. But that's just my opinion. I'm fine if we close the bug as won't fix. |
Created attachment 1975105 [details] Inconsistent edit icons Description of problem: The edit icon (pencil) appears frequently in the UI. Sometimes it appears with a label ("Edit") and sometimes without. I recommend that this be standardized so that the label is removed.