Bug 2221970

Summary:	python-SecretStorage fails to build with Sphinx 7.x
Product:	[Fedora] Fedora	Reporter:	Karolina Surma <ksurma>
Component:	python-SecretStorage	Assignee:	Charalampos Stratakis <cstratak>
Status:	NEW ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	low
Version:	39	CC:	cstratak, projects.rg, python-packagers-sig, redhat-bugzilla, torsava
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2188968

Description Karolina Surma 2023-07-11 11:54:04 UTC

python-SecretStorage fails to build with Sphinx 7.x in Fedora 39 (currently Rawhide).

The issue detected:
```
+ /usr/bin/python3 setup.py build_sphinx -b html

usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
or: setup.py --help [cmd1 cmd2 ...]
or: setup.py --help-commands
or: setup.py cmd --help

error: invalid command 'build_sphinx'
```

Sphinx 7 has removed the setuptools integration (see: https://github.com/sphinx-doc/sphinx/pull/11363).
`setup.py` has been long deprecated and projects are encouraged to migrate away from using it.


For the logs from testing build attempts, see:
https://copr.fedorainfracloud.org/coprs/ksurma/doc-stack/package/python-SecretStorage/

You can test you package in mock running:

$ mock -r fedora-rawhide-x86_64 --addrepo=https://download.copr.fedorainfracloud.org/results/ksurma/doc-stack/fedora-rawhide-x86_64/ --no-clean your.src.rpm
$ mock -r fedora-rawhide-x86_64 --addrepo=https://download.copr.fedorainfracloud.org/results/ksurma/doc-stack/fedora-rawhide-x86_64/ shell

We'd like to include Sphinx 7 in Fedora 39.
Let us know here if you have any questions. Thank you!

Comment 1 Charalampos Stratakis 2023-07-11 13:33:49 UTC

SecretStorage changed to pyproject.toml: https://github.com/mitya57/secretstorage/commit/2315f06939fd0afa287f858b4004aa181eb500a4

However no new version is out yet. I could try to backport the changes or wait. However there is no need to be blocked on this package, feel free to proceed with the Sphinx update at your convenience and I'll take care of it when I find the time.

Comment 2 Fedora Release Engineering 2023-08-16 07:19:10 UTC

This bug appears to have been reported against 'rawhide' during the Fedora Linux 39 development cycle.
Changing version to 39.