Bug 2222110

Summary: Erroneous setuptools dependency
Product: [Fedora] Fedora Reporter: Коренберг Марк <socketpair>
Component: freeipaAssignee: IPA Maintainers <ipa-maint>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: abokovoy, ftrivino, infra-sig, ipa-maint, jonathan, mhjacks, ngompa13, pvoborni, python-packagers-sig, rcritten, ssorce, twoerner
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-08-07 12:43:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Коренберг Марк 2023-07-11 20:44:29 UTC
.spec file:

%if 0%{?rhel} && 0%{?rhel} == 8
Requires: platform-python-setuptools
%else
Requires: python3-setuptools
%endif


Actually, this package (python3-ipalib) does not require setuptools to work.

Please remove this dependency.


Also, I'm kindly asking to backport the change to  Fedora up to 37.

Comment 1 Jonathan Wright 2023-08-04 14:53:18 UTC
Where is your code snippet from? It does not exist in the spec file for python-freeipa and I cannot locate the package that contains it.

setuptools is required for building python-freeipa which you've attached this bug report to.

Comment 2 Коренберг Марк 2023-08-07 07:04:02 UTC
freeipa-4.10.2-1.fc39.3.src.rpm


line 872

Comment 3 Коренберг Марк 2023-08-07 07:05:24 UTC
I'm not against `BuildRequires:`. I'm against `Requires:`

Comment 4 Jonathan Wright 2023-08-07 12:32:58 UTC
Moving this to the proper component.

Comment 5 Alexander Bokovoy 2023-08-07 12:41:17 UTC
This is still a valid requirement. It was added upstream in this commit:

commit 99b8499513915646dd6efe6d0f6a320b3e969190
Author: Petr Voborník <pvoborni>
Date:   Fri Jun 19 14:01:50 2015 +0200

    add python-setuptools to requires
    
    Commit 9f049ca14403f3696d54d186e6b1b15181f055df introduced dependency on
    python-setuptools on line:
      from pkg_resources import parse_version
    
    This dependency is missing on minimal installation and then ipa-server-upgrade
    fails on rpm install/upgrade.
    
    Reviewed-By: Martin Basti <mbasti>

Comment 6 Alexander Bokovoy 2023-08-07 12:43:57 UTC
$ rpm -qf /usr/lib/python3.11/site-packages/pkg_resources/__init__.py
python3-setuptools-65.5.1-2.fc38.noarch

We still have plenty of code in FreeIPA that depends on this import.