Bug 2222191

Summary: [cnv-4.12] manually increasing the number of virt-api pods does not work
Product: Container Native Virtualization (CNV) Reporter: Barak <bmordeha>
Component: VirtualizationAssignee: sgott
Status: ON_QA --- QA Contact: Kedar Bidarkar <kbidarka>
Severity: high Docs Contact:
Priority: high    
Version: 4.12.5CC: acardace
Target Milestone: ---   
Target Release: 4.12.6   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: hco-bundle-registry-container-v4.12.6-8 virt-launcher-container-v4.12.6-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2227746    
Bug Blocks:    

Description Barak 2023-07-12 08:17:09 UTC
--------------------------------------------------
Description of problem:
--------------------------------------------------
as a part of the new KubeVirt rate limiting testing, I tried to increase the number of virt-api pods using this which had no issues before,
I suspect the new auto virt-api auto-scaler overwrites the manual patch.

================================================================================================
apiVersion: hco.kubevirt.io/v1beta1
kind: HyperConverged
metadata:
  annotations:
    deployOVS: "false"
    hco.kubevirt.io/tuningPolicy: '{"qps":200,"burst":400}'
    kubevirt.kubevirt.io/jsonpatch: '[{"op": "add", "path": "/spec/customizeComponents/patches",
      "value": [{"resourceType": "Deployment", "resourceName": "virt-api", "type":
      "json", "patch": "[{\"op\": \"replace\", \"path\": \"/spec/replicas\", \"value\":
      6}]"}]}]'
=================================================================================================
oc get deployment virt-api -o yaml

readyReplicas: 2
  replicas: 2
  updatedReplicas: 2
=================================================================================================
oc -n openshift-cnv get kubevirt kubevirt -o yaml

customizeComponents:
      patches:
      - patch: '[{"op": "replace", "path": "/spec/replicas", "value": 6}]'
        resourceName: virt-api
        resourceType: Deployment
        type: json
=================================================================================================
Boaz Ben Shabat, 10:29 AM
[root@e29-h19-740xd storms_tool]# oc get pod -n openshift-cnv|grep virt-api
virt-api-8795754c5-npd5m                               1/1     Running   1               30h
virt-api-8795754c5-v8tn5                               1/1     Running   1               30h
=================================================================================================


--------------------------------------------------
Version-Release number of selected component (if applicable):
--------------------------------------------------


--------------------------------------------------
How reproducible:
--------------------------------------------------
every time.

--------------------------------------------------
Steps to Reproduce:
--------------------------------------------------

apply the following patch:

oc patch hco -n openshift-cnv kubevirt-hyperconverged --type=merge -p '{"metadata":{"annotations":{"kubevirt.kubevirt.io/jsonpatch":"[{\"op\": \"add\", \"path\": \"/spec/customizeComponents/patches\", \"value\": [{\"resourceType\": \"Deployment\", \"resourceName\": \"virt-api\", \"type\": \"json\", \"patch\": \"[{\\\"op\\\": \\\"replace\\\", \\\"path\\\": \\\"/spec/replicas\\\", \\\"value\\\": 6}]\"}]}]"}}}'


--------------------------------------------------
Expected results:
--------------------------------------------------
the number of virt-api pods should increase to 6