Bug 2222238

Summary: Traceback after invoking firewall-cmd with disabled firewalld
Product: [Fedora] Fedora Reporter: Robin Hack <rhack>
Component: firewalldAssignee: Eric Garver <egarver>
Status: NEW --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 38CC: egarver, psutter
Target Milestone: ---Keywords: RFE
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Robin Hack 2023-07-12 11:23:39 UTC
firewall-cmd returns traceback when firewalld is disabled.

Reproducer:



# systemctl stop  firewalld.service

# firewall-cmd
Error: Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/firewall/client.py", line 50, in _impl
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/firewall/client.py", line 3145, in get_property
    return dbus_to_python(self.fw_properties.Get(
                          ^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'Get'

Proposal: Maybe no traceback when firewalld is disabled?

Reproducible: Always

Steps to Reproduce:
1. systemctl stop  firewalld.service
2. firewall-cmd
Actual Results:  
Error: Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/firewall/client.py", line 50, in _impl
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/firewall/client.py", line 3145, in get_property
    return dbus_to_python(self.fw_properties.Get(
                          ^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'Get'

Expected Results:  
Something beautiful and more user friendly.