Bug 2222579

Summary: PNG screendump doesn't save screen correctly
Product: Red Hat Enterprise Linux 9 Reporter: smitterl
Component: qemu-kvmAssignee: Marc-Andre Lureau <marcandre.lureau>
qemu-kvm sub component: Graphics QA Contact: Guo, Zhiyi <zhguo>
Status: VERIFIED --- Docs Contact:
Severity: medium    
Priority: medium CC: gveitmic, jinzhao, juzhang, virt-maint, zhguo
Version: 9.3Keywords: Regression, Triaged
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Unspecified   
Whiteboard:
Fixed In Version: qemu-kvm-8.0.0-8.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screen graphics comparison: left is screenshot right is actual screen via vnc none

Description smitterl 2023-07-13 07:39:55 UTC 
Created attachment 1975542 [details]
Screen graphics comparison: left is screenshot right is actual screen via vnc

Created attachment 1975542 [details]
Screen graphics comparison: left is screenshot right is actual screen via vnc

Description of problem:
When doing a screendump, the colors are not right (s. attachment).

Version-Release number of selected component (if applicable):
qemu-kvm-8.0.0-6.el9.s390x


How reproducible:
100%


Steps to Reproduce:
1. Start a VM with graphics
2. Take a screenshot (e.g. virsh screenshot vm 
3. Compare the screenshot with the actual graphics

Actual results:
Colors are wrong

Expected results:
The view is the same

Additional info:
Zhiyi Guo found this is likely the upstream issue https://gitlab.com/qemu-project/qemu/-/issues/1622 with upstream commit https://gitlab.com/qemu-project/qemu/-/commit/9acb3d7e5202b3e667f12829c8d553f8574d1743
I'll see if this fixes the issue.
Fangge confirmed it reproduces on x86_64
Comment 4 smitterl 2023-07-13 10:00:58 UTC 
(In reply to smitterl from comment #0)

> 
> Additional info:
> Zhiyi Guo found this is likely the upstream issue
> https://gitlab.com/qemu-project/qemu/-/issues/1622 with upstream commit
> https://gitlab.com/qemu-project/qemu/-/commit/
> 9acb3d7e5202b3e667f12829c8d553f8574d1743

With latest upstream release 8.0.3 that contains this commit, the output looks good.
> I'll see if this fixes the issue.
> Fangge confirmed it reproduces on x86_64
Comment 5 John Ferlan 2023-07-13 18:26:26 UTC 
Marc-Andre - can we get this backported for 9.3.0 please. 

If you'd like to provide thoughts related to a 9.2.0 z-stream please do so. I'm not convinced without proof that this would affect our LPs like OpenShift or OpenStack
Comment 6 Marc-Andre Lureau 2023-07-15 13:10:25 UTC 
(In reply to John Ferlan from comment #5)
> If you'd like to provide thoughts related to a 9.2.0 z-stream please do so.
> I'm not convinced without proof that this would affect our LPs like
> OpenShift or OpenStack

It should be as "easy" to backport for 9.2.0 (qemu-kvm-7.2.0-14.el9_2.N ?). Indeed, I am not convinced many users are using the PNG format, and it's not critical either to have bad colors.
Comment 8 Yanan Fu 2023-07-18 11:22:06 UTC 
QE bot(pre verify): Set 'Verified:Tested,SanityOnly' as gating/tier1 test pass.
Comment 12 Guo, Zhiyi 2023-08-07 03:00:06 UTC 
Verified this issue against qemu-kvm-8.0.0-9.el9.x86_64, screen capture with png format show correct color