Bug 2222744

Summary:	`pcs property describe` does not raise an error for non-existent properties
Product:	Red Hat Enterprise Linux 9	Reporter:	Michal Pospisil <mpospisi>
Component:	pcs	Assignee:	Peter Romancik <promanci>
Status:	POST ---	QA Contact:	cluster-qe <cluster-qe>
Severity:	low	Docs Contact:
Priority:	low
Version:	9.3	CC:	cluster-maint, idevat, mlisik, mpospisi, omular, tojeline
Target Milestone:	rc	Keywords:	Triaged
Target Release:	9.4
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: Filter function skipped check for properties without metadata in commands `pcs property describe` and `pcs property defaults`. Consequence: If specified properties in the commands `pcs property describe` and `pcs property defaults` did not have metadata no error was displayed. Fix: Fix filter function to check properties without metadata. Result: If specified properties in the commands do not have metadata error message is printed.	Story Points:	---
Clone Of:
Clones:	2226778 (view as bug list)		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2226778

Description Michal Pospisil 2023-07-13 15:47:23 UTC

Description of problem:
When a cluster property that does not exist is supplied to the `pcs property describe` command, nothing is printed out and the return value is 0 (success). There should be some kind of an error in this case.

Version-Release number of selected component (if applicable):
pcs-0.11.6-2.el9

How reproducible:
always, easily

Steps to Reproduce:
1. Run `pcs property describe nonexistent`

Actual results:
# pcs property describe nonexistent

# echo $?
0

Expected results:
An error is printed and pcs exits with a non-zero return code. 

Additional info:

Comment 1 Peter Romancik 2023-08-01 08:11:24 UTC

Upstream commit: https://github.com/ClusterLabs/pcs/commit/91852cc4971c9002bd1cefc250bdca57ba68fbbd

Updated commands:
* pcs property describe
* pcs property defaults

Test:
# pcs property describe nonexistent
Error: No description for property: 'nonexistent'
# echo $?
1

# pcs property defaults nonexistent1 nonexistent2
Error: No default value for properties: 'nonexistent1', 'nonexistent2'
# echo $?
1