Bug 2222811

Summary:	Review Request: apache-commons-jexl - Java Expression Language
Product:	[Fedora] Fedora	Reporter:	Jerry James <loganjerry>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://commons.apache.org/proper/commons-jexl/
Whiteboard:
Fixed In Version:	apache-commons-jexl-3.3-1.fc39	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-07-18 15:16:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2223473

Description Jerry James 2023-07-13 19:52:05 UTC

Spec URL: https://jjames.fedorapeople.org/apache-commons-jexl/apache-commons-jexl.spec
SRPM URL: https://jjames.fedorapeople.org/apache-commons-jexl/apache-commons-jexl-3.3-1.fc39.src.rpm
Fedora Account System Username: jjames
Description: JEXL is a library intended to facilitate the implementation of scripting features in applications and frameworks written in Java.  JEXL implements an Expression Language based on some extensions to the JSTL Expression Language supporting most of the constructs seen in shell script or ECMAScript.  Its goal is to expose scripting features usable by technical operatives or consultants working with enterprise platforms.

Comment 1 Fedora Review Service 2023-07-13 19:59:09 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6170463
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2222811-apache-commons-jexl/fedora-rawhide-x86_64/06170463-apache-commons-jexl/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-07-17 19:21:45 UTC

fedora-review is broken in rawhide, so here's a manual review:

- package name matches other Apache commons-* projects
- latest version is packaged
- Summary / description are fine and correctly line-wrapped
- source archive contains only source files and no objectionable content
- source archive contains only files under Apache-2.0 license
- License matches upstream specification, license text included
- signature of source file verified with gpg
- Patch to replace one build dependency with another one documented and justified
- BuildRequires look sane (though I could not verify them, xmvn-builddep seems to be broken again)
- docs are built and included in a separate package
- removal of unnecessary maven plugins is fine and justified
- build uses standard mvn_build / mvn_install macros
- unit tests are run and are all successful
- included %files look sane
- looks good to me

Package APPROVED.

===

You can continue the unretirement process with releng.

Note that if you want to preserve pre-retirement changelog, you'll probably need to be careful when converting to rpmautospec (I think running "rpmautospec convert" immediately after the unretirement commit and then commiting your new version on top of that should work).

Comment 3 Jerry James 2023-07-17 20:06:56 UTC

Thank you for the review.  I somehow failed to realize this package had been in Fedora before, so thanks for pointing that out too.  I'll try your suggestion for preserving the changelog.

Comment 4 Jerry James 2023-07-18 15:16:07 UTC

Version 3.3 has been built in Rawhide.  And, sure enough, I messed up the changelog.  I have pushed another commit that should fix it.  It will go into effect when the mass rebuild builds this package.