Bug 2222844
| Summary: | Review Request: qoi - The “Quite OK Image Format” for fast, lossless image compression | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ryan <errornointernet> | ||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | fedora, package-review | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://github.com/phoboslab/qoi | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Ryan
2023-07-14 05:44:11 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6171803 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2222844-qoi/fedora-rawhide-x86_64/06171803-qoi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Updated .spec file to also include the -devel package. New .spec URL: https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06172030-qoi/qoi.spec New .srpm URL: https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06172030-qoi/qoi-20230615git36190eb-2.fc39.src.rpm *** Bug 2222846 has been marked as a duplicate of this bug. *** Created attachment 1975737 [details]
The .spec file difference from Copr build 6171803 to 6172039
Copr build: https://copr.fedorainfracloud.org/coprs/build/6172039 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2222844-qoi/fedora-rawhide-x86_64/06172039-qoi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > %install > mkdir -p %{buildroot}/%{_includedir} > cp qoi.h %{buildroot}/%{_includedir} 1. You should aim to preserve file timestamps. You can use "cp -a" or "cp --preserve=timestamps". https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps 2. Using "cp" is fine, but I think that most .spec files use "install" instead. "install -d" can also be used to create directories. > %files devel > %license LICENSE > %doc README.md The -devel package has a hard "Requires:" on the base package, so these files can be omitted. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing Also, looking at the copr build made by the review service: > gcc -std=c99 -O3 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer qoiconv.c -o qoiconv This does not include Fedora's LDFLAGS. You'll need to either modify the Makefile to include those in the gcc invocation, or call the compiler manually. Thanks for your reply :) > This does not include Fedora's LDFLAGS. You'll need to either modify the Makefile to include those in the gcc invocation, or call the compiler manually. I have now added a patch (Makefile-ldflags.patch) for the Makefile to include LDFLAGS. Changes: - Used `install -d` and `install -p` instead of `cp` - Added `Requires: %{name}%{?isa} = %{version}-%{release}` to the -devel package - Added LDFLAGS patch New .spec URL: https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06176114-qoi/qoi.spec New .srpm URL: https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06176114-qoi/qoi-20230615git36190eb-3.fc39.src.rpm Makefile-ldflags.patch: https://github.com/ErrorNoInternet/rpm-specs/raw/main/qoi/Makefile-ldflags.patch |