Bug 2222846

Summary: Review Request: qoi-devel - The “Quite OK Image Format” for fast, lossless image compression
Product: [Fedora] Fedora Reporter: Ryan <errornointernet>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: fedora, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://github.com/phoboslab/qoi
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-07-14 08:53:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ryan 2023-07-14 05:46:48 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06171790-qoi-devel/qoi-devel.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/errornointernet/qoi/fedora-rawhide-x86_64/06171790-qoi-devel/qoi-devel-20230615git36190eb-1.fc39.src.rpm

Upstream: https://github.com/phoboslab/qoi
Description: Header files (qoi.h) for fast, lossless image compression using the "Quite OK Image Format".
Fedora Account System Username: errornointernet

Sorry for any mistakes made.
This is one of my first packages, and I am in need of a sponsor.

Comment 1 Fedora Review Service 2023-07-14 05:51:41 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6171805
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2222846-qoi-devel/fedora-rawhide-x86_64/06171805-qoi-devel/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Artur Frenszek-Iwicki 2023-07-14 08:04:03 UTC
RPM allows you to build multiple packages from the same spec file.
qoi-devel should be a sub-package built from the main qoi.spec, not an entirely separate package.

You can check out these articles for more info:
- https://ftp.rpm.org/max-rpm/ch-rpm-subpack.html
- https://blog.svgames.pl/article/building-multiple-packages-with-rpm

Or take a look at some packages already present in Fedora:
- https://src.fedoraproject.org/rpms/SFML/blob/26fb67ca673572705986a59956398ae107424abe/f/SFML.spec
- https://src.fedoraproject.org/rpms/liblcf/blob/b6e010f862fdbccb3bd1143e6977262b137df54f/f/liblcf.spec

Comment 3 Ryan 2023-07-14 08:53:24 UTC
Ahh I see. Thanks for providing example packages.

I'll be closing this in favor of https://bugzilla.redhat.com/show_bug.cgi?id=2222844 then.

*** This bug has been marked as a duplicate of bug 2222844 ***