Bug 2223011
| Summary: | Review Request: python-chalice - Python Serverless Microframework for AWS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> | ||||
| Component: | Package Review | Assignee: | Michel Alexandre Salim <michel> | ||||
| Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | michel, package-review | ||||
| Target Milestone: | --- | Flags: | michel:
fedora-review?
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | https://github.com/aws/chalice | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 2223010 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Davide Cavalca
2023-07-14 20:27:55 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6173865 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2223011-python-chalice/fedora-rawhide-x86_64/06173865-python-chalice/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Initial pass: - could use %pyproject_buildrequires -r requirements-test.in (requirements-test.txt locks in the versions required). that way you don't have to manually specify test dependencies - patch requirements-test.in so it does not pull in python3-mock which is deprecated. And patch the callsites to do `from unittest import mock` rather than `import mock` and upstream that potentially use try / except: try: from unittest import mock except: import mock Note that somehow it doesn't pick up `python3dist(inquirer)` even though I point fedora-review to the correct local repo $ rpm -qp --provides ../../repo/python3-inquirer-3.1.3-1.fc38.noarch.rpm python-inquirer = 3.1.3-1.fc38 python3-inquirer = 3.1.3-1.fc38 python3.11-inquirer = 3.1.3-1.fc38 python3.11dist(inquirer) = 3.1.3 python3dist(inquirer) = 3.1.3 inquirer got picked up fine, I just passed the path to the local repo wrong. So yeah, using requirements-test.in works, and please also patch the mock dependency out and send a patch upstream Spec URL: https://dcavalca.fedorapeople.org/review/python-chalice/python-chalice.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-chalice/python-chalice-1.29.0-1.fc39.src.rpm Changelog: - use unittest.mock and requirements-test.in Created attachment 1980306 [details]
The .spec file difference from Copr build 6173865 to 6217857
Copr build: https://copr.fedorainfracloud.org/coprs/build/6217857 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2223011-python-chalice/fedora-rawhide-x86_64/06217857-python-chalice/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. |