Bug 2223036

Summary: facts being gathered unnecessarily
Product: Red Hat Enterprise Linux 8 Reporter: Rich Megginson <rmeggins>
Component: rhel-system-rolesAssignee: Rich Megginson <rmeggins>
Status: ON_QA --- QA Contact: David Jež <djez>
Severity: unspecified Docs Contact: Lucie Vařáková <lmanasko>
Priority: unspecified    
Version: 8.9CC: djez, jharuda, lmanasko, rhel-cs-system-management-subsystem-qe, spetrosi, vdanek
Target Milestone: rcKeywords: Triaged
Target Release: 8.9Flags: rmeggins: needinfo? (djez)
rmeggins: needinfo? (vdanek)
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: role:ALL
Fixed In Version: rhel-system-roles-1.22.0-0.16.el8 Doc Type: Bug Fix
Doc Text:
Cause: The comparison of the present facts with the required facts is being done on unsorted lists. Consequence: The comparison may fail if the only difference is the order. Facts are gathered unnecessarily. Fix: Use difference which works no matter what the order is. Ensure that the fact gathering subsets used are the absolute minimum required. Result: The role gathers only the facts it requires, and does not unnecessarily gather facts.
Story Points: ---
Clone Of: 2223032 Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2223032    
Bug Blocks:    

Description Rich Megginson 2023-07-14 21:57:58 UTC
+++ This bug was initially created as a clone of Bug #2223032 +++

Cause: The comparison of the present facts with the required facts is
being done on unsorted lists.

Consequence: The comparison may fail if the only difference is the
order.  Facts are gathered unnecessarily.

Fix: Use `difference` which works no matter what the order is.  Ensure
that the fact gathering subsets used are the absolute minimum required.

Result: The role gathers only the facts it requires, and does
not unnecessarily gather facts.

original issue https://github.com/linux-system-roles/storage/issues/373
storage fix https://github.com/linux-system-roles/storage/pull/374

Comment 5 Rich Megginson 2023-07-19 18:25:28 UTC
Here is the script which can check logs https://github.com/linux-system-roles/auto-maintenance/pull/286