Bug 222308
Summary: | mkfs and journal addition for GFS2 should produce contiguous journals | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 5 | Reporter: | Steve Whitehouse <swhiteho> | ||||||||
Component: | gfs2-utils | Assignee: | Robert Peterson <rpeterso> | ||||||||
Status: | CLOSED ERRATA | QA Contact: | Cluster QE <mspqa-list> | ||||||||
Severity: | medium | Docs Contact: | |||||||||
Priority: | low | ||||||||||
Version: | 5.0 | ||||||||||
Target Milestone: | --- | ||||||||||
Target Release: | --- | ||||||||||
Hardware: | All | ||||||||||
OS: | Linux | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | RHBA-2007-0579 | Doc Type: | Bug Fix | ||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | 2007-11-07 18:04:27 UTC | Type: | --- | ||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Bug Depends On: | |||||||||||
Bug Blocks: | 221743 | ||||||||||
Attachments: |
|
Description
Steve Whitehouse
2007-01-11 16:00:46 UTC
Created attachment 147527 [details]
Patch to allow contiguous journal allocation from mkfs
This patch seems to do the trick, but it hasn't had a lot of testing.
You'll have to make libgfs2.a then relink mkfs.gfs2 to pick it up.
Ok, it looks good to me, thanks for sorting that one out. Did you try testing it against fsck? If that works and it appears to work ok with current gfs2 with various numbers of journals then I guess the next stage is to get it into the FC package. Once its been there for a little while I think we can then says its safe enough for RHEL5.1 Does that seem like a reasonable plan? Created attachment 147620 [details]
Better patch to fix the problem
This version is better. It fixes a nasty problem plus it makes
gfs2_fsck call a common function in libgfs that mkfs also uses for
building the journals.
Created attachment 147922 [details]
Final patch to fix the problem
The previous patch caused a problem with gfs2_fsck writing too much data
when reinitializing the journals. This libgfs2 patch fixes that problem.
This one has had more testing and works for both mkfs.gfs2 and gfs2_fsck.
This one will be committed to CVS for HEAD and RHEL5.
Fix committed to CVS at HEAD and RHEL5. Both mkfs.gfs2 and gfs2_fsck were tested on trin-10 using a variety of journal sizes. Changing status to modified. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2007-0579.html |